| Summary: | Text Autosizing: Add explanations to tests. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | John Mellor <johnme> | ||||||
| Component: | Layout and Rendering | Assignee: | John Mellor <johnme> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, eric, jchaffraix, kenneth, peter, satish, simon.fraser, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 84186 | ||||||||
| Attachments: |
|
||||||||
|
Description
John Mellor
2012-09-13 11:01:43 PDT
Created attachment 163911 [details]
Patch
Comment on attachment 163911 [details]
Patch
rs=me
Comment on attachment 163911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163911&action=review > LayoutTests/fast/text-autosizing/font-scale-factor-expected.html:6 > +<style type="text/css"> The 'type' attribute is not required. > LayoutTests/fast/text-autosizing/font-scale-factor-expected.html:15 > + This text should be autosized to 80px computed font-size (16 * 800/320 * 2, where 2 is the fontScaleFactor). Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur sapien sapien, tempus id egestas a, consectetur et felis. Ut pharetra mi eget lectus laoreet rutrum. Mauris tellus odio, egestas vitae sodales in, vehicula eget ante. Pellentesque id egestas arcu. Quisque tellus quam, rhoncus ac elementum vel, volutpat vel felis. Aliquam ut leo dolor, eget egestas tellus. Nunc ut velit gravida nisl fringilla rutrum eget at arcu. Vivamus et pretium mauris. Putting the explanation on its own line would make the text more readable (not repeated on all the tests). > LayoutTests/fast/text-autosizing/narrow-iframe-expected.html:7 > -body { width: 800px; margin: 0; overflow-y: hidden; } > +body { width: 800px; margin: 0; } If you remove those, you will check that we don't overflow in those tests. Not sure if it's super useful as you set the height to be tall enough anyway. > LayoutTests/fast/text-autosizing/narrow-iframe.html:7 > -body { width: 800px; margin: 0; overflow-y: hidden; } > +body { width: 800px; margin: 0; } Ditto. Created attachment 163942 [details]
Patch
Comment on attachment 163942 [details]
Patch
r=me, thanks for making the tests more awesome.
Comment on attachment 163942 [details] Patch Clearing flags on attachment: 163942 Committed r128500: <http://trac.webkit.org/changeset/128500> All reviewed patches have been landed. Closing bug. |