Summary: | REGRESSION: transition doesn’t always override transition-property | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lea Verou <lea> | ||||
Component: | CSS | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarcelo, dino, macpherson, menard, simon.fraser, webkit-bug-importer, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
URL: | http://result.dabblet.com/gist/3715069 | ||||||
Attachments: |
|
Description
Lea Verou
2012-09-13 08:56:54 PDT
That does seem like a bug. Interesting. In debug, we hit: ASSERTION FAILED: prop >= firstCSSProperty && prop < (firstCSSProperty + numCSSProperties) When parsing the shorthand, CSSParser::parseTransitionShorthand() fills in unsupplied values with the "initial" value: // Fill in any remaining properties with the initial value. for (i = 0; i < numProperties; ++i) { if (!parsedProperty[i]) addAnimationValue(values[i], cssValuePool().createImplicitInitialValue()); } and later on we take this to imply that we should use Animation::initialAnimationProperty() which is CSSPropertyInvalid. Maybe that should be All? Regressed with http://trac.webkit.org/changeset/113225 when Alexis changed initialAnimationProperty() to return CSSPropertyInvalid rather than cAnimateAll. Also, the use of CSSPropertyID in platform/animation code is a layering violation. Possibly seeing this (the assertion at least) on http://davidcelis.com/blog/2012/09/06/stop-validating-email-addresses-with-regex/?utm_source=rubyweekly&utm_medium=email Created attachment 164228 [details]
Patch
Build fix in http://trac.webkit.org/changeset/128660 |