Bug 96646

Summary: [EFL] Gardening of failing tests
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, lucas.de.marchi, naginenis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
webkit.review.bot: commit-queue-
Patch none

Mikhail Pozdnyakov
Reported 2012-09-13 07:20:29 PDT
inspector/profiler/memory-instrumentation-cached-images.html fails after r128451.
Attachments
patch (1.97 KB, patch)
2012-09-13 07:30 PDT, Mikhail Pozdnyakov 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (1.31 KB, patch)
2012-09-14 05:56 PDT, Sudarsana Nagineni (babu) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-09-13 07:30:41 PDT
Created attachment 163867 [details] patch Also marked media/video-seek-past-end-playing.html and loader/go-back-to-different-window-size.htm as flaky because they fail from time to time making bot red. Haven't managed both to reproduce failures locally and identify the revision causing failures, as they fail occasionally within the whole bot history.
WebKit Review Bot
Comment 2 2012-09-13 08:09:02 PDT
Comment on attachment 163867 [details] patch Rejecting attachment 163867 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: s/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/efl/TestExpectations Hunk #2 FAILED at 1061. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/efl/TestExpectations.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/13847201
Sudarsana Nagineni (babu)
Comment 3 2012-09-14 05:47:28 PDT
inspector/profiler/memory-instrumentation-cached-images.html is passing after r128463. I will update the patch and skip only flaky tests on efl-wk1.
Sudarsana Nagineni (babu)
Comment 4 2012-09-14 05:56:26 PDT
Created attachment 164122 [details] Patch
WebKit Review Bot
Comment 5 2012-09-14 06:37:00 PDT
Comment on attachment 164122 [details] Patch Clearing flags on attachment: 164122 Committed r128605: <http://trac.webkit.org/changeset/128605>
WebKit Review Bot
Comment 6 2012-09-14 06:37:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.