Bug 96630

Summary: [EFL] Gardening after r128375, r128431
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: WebKit EFLAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, gyuyoung.kim, kenneth, lucas.de.marchi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
webkit.review.bot: commit-queue-
included binary diff none

Mikhail Pozdnyakov
Reported 2012-09-13 03:56:28 PDT
Need to rebase: fast/table/height-percent-test-vertical.html fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks.html and unskip fast/overflow/overflow-height-float-not-removed-crash.html passing after r128431.
Attachments
patch (6.31 KB, patch)
2012-09-13 04:02 PDT, Mikhail Pozdnyakov 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
included binary diff (6.98 KB, patch)
2012-09-13 04:39 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2012-09-13 04:02:32 PDT
Created attachment 163830 [details] patch
WebKit Review Bot
Comment 2 2012-09-13 04:15:42 PDT
Comment on attachment 163830 [details] patch Rejecting attachment 163830 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: "Binary files a/LayoutTests/platform/efl/fast/table/height-percent-test-vertical-expected.png and b/LayoutTests/platform/efl/fast/table/height-percent-test-vertical-expected.png differ". Be sure to use the --binary flag when invoking "git diff" with diffs containing binary files. at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 709, <ARGV> line 44. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 9 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/13845152
Mikhail Pozdnyakov
Comment 3 2012-09-13 04:39:40 PDT
Created attachment 163839 [details] included binary diff
WebKit Review Bot
Comment 4 2012-09-13 05:08:22 PDT
Comment on attachment 163839 [details] included binary diff Clearing flags on attachment: 163839 Committed r128446: <http://trac.webkit.org/changeset/128446>
WebKit Review Bot
Comment 5 2012-09-13 05:08:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.