Bug 96621

Summary: [Gtk] Remove configuration options for stable features that are currently enabled
Product: WebKit Reporter: Zan Dobersek <zan>
Component: WebKitGTKAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: adamk, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 87126    
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2012-09-13 01:27:48 PDT 
Configuration options for features that are enabled by default should be removed if the feature doesn't introduce dependencies and is considered stable.
Comment 1 Zan Dobersek 2012-09-17 10:49:00 PDT 
Created attachment 164418 [details]
Patch
Comment 2 Martin Robinson 2012-09-17 10:51:29 PDT 
Comment on attachment 164418 [details]
Patch

Great!
Comment 3 Zan Dobersek 2012-09-17 10:57:36 PDT 
Comment on attachment 164418 [details]
Patch

Clearing flags on attachment: 164418

Committed r128776: <http://trac.webkit.org/changeset/128776>
Comment 4 Zan Dobersek 2012-09-17 10:57:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Klein 2012-10-01 13:52:35 PDT 
I see that this patch put DOM MutationObservers in the "unstable features" bucket. Can you explain a bit of the background for that? I ask because I'd like to remove the ENABLE_MUTATION_OBSERVERS #define, since it's been enabled by default everywhere for awhile (and seems to be shipping in several WebKit-based browsers, including Safari and Chrome).
Comment 6 Martin Robinson 2012-10-01 13:55:04 PDT 
(In reply to comment #5)
> I see that this patch put DOM MutationObservers in the "unstable features" bucket. Can you explain a bit of the background for that? I ask because I'd like to remove the ENABLE_MUTATION_OBSERVERS #define, since it's been enabled by default everywhere for awhile (and seems to be shipping in several WebKit-based browsers, including Safari and Chrome).

It probably just wasn't turned on for stable releases as an oversight. If it's stable enough to ship, feel free to just remove the option, I'd say.
Comment 7 Zan Dobersek 2012-10-02 03:27:59 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > I see that this patch put DOM MutationObservers in the "unstable features" bucket. Can you explain a bit of the background for that? I ask because I'd like to remove the ENABLE_MUTATION_OBSERVERS #define, since it's been enabled by default everywhere for awhile (and seems to be shipping in several WebKit-based browsers, including Safari and Chrome).
> 
> It probably just wasn't turned on for stable releases as an oversight. If it's stable enough to ship, feel free to just remove the option, I'd say.

That's the case, GTK port shouldn't pose any obstacles for removing this define, so proceed at will.