Bug 96594

Summary: fast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chromium-Mac, GTK, EFL
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, jamesr, ojan, slewis, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+

Comment 1 Zan Dobersek 2012-09-12 23:46:09 PDT
Fails on EFL and GTK as well:

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/table/bad-replaced-sizing-preferred-logical-widths-expected.txt 
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/table/bad-replaced-sizing-preferred-logical-widths-actual.txt 
@@ -3,5 +3,8 @@
 This test checks that a replaced element inside an auto-table layout properly computes its preferred logical width.
 
 
-PASS
+FAIL:
+Expected 602 for width, but got 598. 
+
+<iframe srcdoc="&lt;!DOCTYPE html&gt;&lt;p&gt;Lorem Ipsum&lt;/p&gt;" width="100%" data-expected-width="602"></iframe>
 dolor sit amet...
Comment 2 Stephanie Lewis 2012-09-13 00:02:21 PDT
New test added in http://trac.webkit.org/projects/webkit/changeset/128389
Comment 3 Ojan Vafai 2012-09-13 15:43:49 PDT
Created attachment 163986 [details]
Patch
Comment 4 Ojan Vafai 2012-09-13 15:51:55 PDT
Committed r128516: <http://trac.webkit.org/changeset/128516>
Comment 5 Julien Chaffraix 2012-09-13 16:27:23 PDT
Comment on attachment 163986 [details]
Patch

Thanks Ojan for picking this up! It seems you didn't remove the TestExpectations on Chromium, Efl, Qt and Mac. Was that intended?
Comment 6 James Robinson 2012-09-13 16:48:21 PDT
(In reply to comment #5)
> (From update of attachment 163986 [details])
> Thanks Ojan for picking this up! It seems you didn't remove the TestExpectations on Chromium, Efl, Qt and Mac. Was that intended?

As a result the tests are failing.  I'll remove the more specific baselines and fix up the LayoutTests/fast/... one
Comment 7 Ojan Vafai 2012-09-13 16:51:39 PDT
Ugh. I thought I had included the new -expected.txt.
Comment 8 James Robinson 2012-09-13 17:01:03 PDT
http://trac.webkit.org/changeset/128528
Comment 9 Ojan Vafai 2012-09-13 17:04:16 PDT
(In reply to comment #8)
> http://trac.webkit.org/changeset/128528

Thx!
Comment 10 Ojan Vafai 2012-09-13 17:11:31 PDT
And http://trac.webkit.org/changeset/128530