Bug 9658

Summary:

REGRESSION: Check Spelling does not work in textarea elements

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

Forms

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, ian, webkit-bugs

Priority:

Keywords:

HasReduction, InRadar, Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

data:text/html,<textarea>

Attachments:

Description	Flags
Patch	justin.garcia: review+

Darin Adler

Reported 2006-06-29 20:14:20 PDT

Go to a web page with a textarea element, like any Bugzilla bug. Click in the textarea. Now choose Check Spelling from the contextual menu. You get a beep, and spell checking does not take place.

Attachments
Patch (4.28 KB, patch) 2006-07-14 13:02 PDT, Anders Carlsson	justin.garcia: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2006-06-29 20:14:52 PDT

The bug is in the WebCore::FrameMac::advanceToNextMisspelling function.

Rosyna

Comment 2 2006-06-29 20:24:55 PDT

How odd, this is what I originally filed bug 9580 on.

Darin Adler

Comment 3 2006-06-30 11:09:37 PDT

(In reply to comment #2) > How odd, this is what I originally filed bug 9580 on. Maybe it's what you meant, but it's not what you wrote in the bug -- I just re-read it to be sure. If you go back and read that bug you'll see that you mentioned "Check Spelling as You Type", which is not the same thing as "Check Spelling". "Check Spelling as You Type" is working now, which is why that bug is marked resolved.

Alice Liu

Comment 4 2006-07-05 12:10:57 PDT

<rdar://problem/4613948>

David Kilzer (:ddkilzer)

Comment 5 2006-07-12 21:16:07 PDT

This seems to be working as of a locally-built WebKit r15401. Please retest. However, setting the WebContinuousSpellCheckingEnabled default doesn't enable this by default for all text fields and text areas. (Perhaps this is a different bug?)

David Kilzer (:ddkilzer)

Comment 6 2006-07-12 21:29:35 PDT

(In reply to comment #5) > However, setting the WebContinuousSpellCheckingEnabled default doesn't enable > this by default for all text fields and text areas. (Perhaps this is a > different bug?) Filed Bug 9887 for this issue.

Anders Carlsson

Comment 7 2006-07-14 13:02:45 PDT

Created attachment 9452 [details] Patch

Justin Garcia

Comment 8 2006-07-14 13:19:32 PDT

Comment on attachment 9452 [details] Patch Hey anders I think you could set the start/end to the first/last nodes in an editable div for all editable divs. I don't think you need to special case shadow divs. but this is just a suggestion. r=me

Justin Garcia

Comment 9 2006-07-14 13:25:57 PDT

Comment on attachment 9452 [details] Patch I think you could also do setEnd(topNode, maxDeepOffset(topNode) setStart(topNode, 0) and remove the logic that you added.

Anders Carlsson

Comment 10 2006-07-14 13:51:17 PDT

Committed revision 15435.

Note You need to log in before you can comment on or make changes to this bug.