Bug 96577

Summary: Remove webkitPostMessage
Product: WebKit Reporter: Adam Barth <abarth>
Component: WebCore JavaScriptAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, dslomov, eric, gtk-ews, gustavo, gyuyoung.kim, haraken, japhet, kbr, mjs, ojan, philn, rakuco, rniwa, syoichi, vestbo, webkit.review.bot, xan.lopez
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch for discussion
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch none

Adam Barth
Reported 2012-09-12 16:47:43 PDT
Remove webkitPostMessage
Attachments
patch for discussion (24.72 KB, patch)
2012-09-12 17:00 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (54.64 KB, patch)
2012-09-13 16:00 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (54.50 KB, patch)
2012-09-13 16:05 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (54.73 KB, patch)
2012-09-13 16:10 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (56.84 KB, patch)
2012-09-13 16:22 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (56.95 KB, patch)
2012-09-13 17:17 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (54.53 KB, patch)
2012-09-14 14:02 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (1.22 KB, patch)
2012-09-19 18:07 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-09-12 17:00:54 PDT
Created attachment 163739 [details] patch for discussion
Eric Seidel (no email)
Comment 2 2012-09-12 17:33:59 PDT
Comment on attachment 163739 [details] patch for discussion OK. Do we have any concept of how much content on teh web depends on this?
Maciej Stachowiak
Comment 3 2012-09-12 18:05:18 PDT
This probably shouldn't be r+'d or committed until the webkit-dev discussion has settled. See thread starting here: http://lists.webkit.org/pipermail/webkit-dev/2012-September/022189.html
Adam Barth
Comment 4 2012-09-12 18:28:36 PDT
> Do we have any concept of how much content on teh web depends on this? We don't have any hard numbers. I wasn't able to find any uses when I looked with various code search tools. As far as I can tell, its existence was only mentioned in one tutorial. > This probably shouldn't be r+'d or committed until the webkit-dev discussion has settled. Yes, I didn't actually mean to set the r? flag. I just wanted to post a patch so that we had something concrete to discuss.
Adam Barth
Comment 5 2012-09-13 16:00:16 PDT
Created attachment 163989 [details] Patch
Adam Barth
Comment 6 2012-09-13 16:00:45 PDT
This updated patch reflects the further discussion on webkit-dev. Let's see if the EWS thinks it builds on all the various ports.
Ojan Vafai
Comment 7 2012-09-13 16:02:19 PDT
Comment on attachment 163989 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163989&action=review > Source/WebCore/GNUmakefile.am:470 > +endif # END ENABLE_LEGACY_WEBKIT_BLOB_BUILDER copy-paste lol > Source/WebCore/workers/Worker.idl:1 > +e/* Not likely to build. :)
Adam Barth
Comment 8 2012-09-13 16:05:16 PDT
Created attachment 163991 [details] Patch
Adam Barth
Comment 9 2012-09-13 16:10:54 PDT
Created attachment 163992 [details] Patch
Adam Barth
Comment 10 2012-09-13 16:22:37 PDT
Created attachment 163995 [details] Patch
kov's GTK+ EWS bot
Comment 11 2012-09-13 16:38:35 PDT
Comment on attachment 163995 [details] Patch Attachment 163995 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13855191
Gyuyoung Kim
Comment 12 2012-09-13 16:54:03 PDT
Comment on attachment 163995 [details] Patch Attachment 163995 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13851300
Build Bot
Comment 13 2012-09-13 17:00:35 PDT
Comment on attachment 163995 [details] Patch Attachment 163995 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13855194
Early Warning System Bot
Comment 14 2012-09-13 17:16:06 PDT
Comment on attachment 163995 [details] Patch Attachment 163995 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13855196
Adam Barth
Comment 15 2012-09-13 17:17:05 PDT
Created attachment 164006 [details] Patch
Adam Barth
Comment 16 2012-09-14 11:17:30 PDT
The bots are green now. Anyone care to review?
Ojan Vafai
Comment 17 2012-09-14 11:19:48 PDT
Comment on attachment 164006 [details] Patch Would be nice to include a brief description in the ChangeLog about why a generic legacy flag makes sense instead of one specific to postmessage (e.g. that once we've confirmed getting rid of it is OK we can just delete this code and avoid the overhead of constantly adding/removing flags per prefix).
Adam Barth
Comment 18 2012-09-14 11:23:58 PDT
Will do. I'm going to wait until Wed to land this patch so that it will have a full Dev cycle to bake.
Adam Barth
Comment 19 2012-09-14 13:53:55 PDT
Actually, I'm going to land this with ENABLE_LEGACY_VENDOR_PREFIXES turned on everywhere and then flip the flag for Chromium on Wed so that this patch doesn't bit rot.
Adam Barth
Comment 20 2012-09-14 14:02:56 PDT
Created attachment 164221 [details] Patch for landing
WebKit Review Bot
Comment 21 2012-09-14 15:04:38 PDT
Comment on attachment 164221 [details] Patch for landing Clearing flags on attachment: 164221 Committed r128658: <http://trac.webkit.org/changeset/128658>
WebKit Review Bot
Comment 22 2012-09-14 15:04:44 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 23 2012-09-14 15:47:20 PDT
Not actually removed quite yet! We still need to flip the enable bit.
Adam Barth
Comment 24 2012-09-19 18:07:58 PDT
Created attachment 164812 [details] Patch
WebKit Review Bot
Comment 25 2012-09-19 19:04:51 PDT
Comment on attachment 164812 [details] Patch Clearing flags on attachment: 164812 Committed r129085: <http://trac.webkit.org/changeset/129085>
WebKit Review Bot
Comment 26 2012-09-19 19:04:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.