Summary: | [CSS Shaders] Cached validated programs are destroyed and recreated when there is only one custom filter animating | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Max Vujovic <mvujovic> | ||||||
Component: | Layout and Rendering | Assignee: | Max Vujovic <mvujovic> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achicu, dino, eric, jacobg, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 71392 | ||||||||
Attachments: |
|
Description
Max Vujovic
2012-09-12 14:42:23 PDT
Created attachment 163721 [details]
Patch
Comment on attachment 163721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163721&action=review > Source/WebCore/rendering/FilterEffectRenderer.cpp:207 > + // New FECustomFilters can reuse cached resources from old FECustomFilters. I think it would be easy to just create a new list and swap it here. It would be similar to clearing m_effects, while still keeping the old ones alive. FilterEffectList oldEffects; m_effects.swap(oldEffects); (In reply to comment #2) > (From update of attachment 163721 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163721&action=review > > > Source/WebCore/rendering/FilterEffectRenderer.cpp:207 > > + // New FECustomFilters can reuse cached resources from old FECustomFilters. > > I think it would be easy to just create a new list and swap it here. It would be similar to clearing m_effects, while still keeping the old ones alive. > > FilterEffectList oldEffects; > m_effects.swap(oldEffects); Sure, I can do that. Created attachment 163724 [details]
Patch
Updated patch based on Alex's informal review.
Comment on attachment 163724 [details] Patch Clearing flags on attachment: 163724 Committed r128387: <http://trac.webkit.org/changeset/128387> All reviewed patches have been landed. Closing bug. |