Bug 96560

Summary: [v8] document.getCSSCanvasContext doesn't need to be custom
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gyuyoung.kim, haraken, japhet, ojan, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Adam Barth
Reported 2012-09-12 14:38:58 PDT
[v8] document.getCSSCanvasContext doesn't need to be custom
Attachments
Patch (5.14 KB, patch)
2012-09-12 14:39 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (7.81 KB, patch)
2012-09-12 14:40 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (9.59 KB, patch)
2012-09-12 15:00 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-09-12 14:39:54 PDT
Created attachment 163695 [details] Patch
Adam Barth
Comment 2 2012-09-12 14:40:57 PDT
Created attachment 163698 [details] Patch
Eric Seidel (no email)
Comment 3 2012-09-12 14:43:43 PDT
Comment on attachment 163698 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163698&action=review > Source/WebCore/bindings/v8/custom/V8CanvasRenderingContextCustom.cpp:45 > + return v8NullWithCheck(isolate); This is now null instead of undefined. Do we care?
Adam Barth
Comment 4 2012-09-12 14:55:04 PDT
(In reply to comment #3) > (From update of attachment 163698 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163698&action=review > > > Source/WebCore/bindings/v8/custom/V8CanvasRenderingContextCustom.cpp:45 > > + return v8NullWithCheck(isolate); > > This is now null instead of undefined. Do we care? I don't really care, but I'll add a test just for you.
Adam Barth
Comment 5 2012-09-12 15:00:48 PDT
Created attachment 163706 [details] Patch
Adam Barth
Comment 6 2012-09-12 15:00:57 PDT
Now with test.
Eric Seidel (no email)
Comment 7 2012-09-12 15:03:30 PDT
Comment on attachment 163706 [details] Patch OK.
WebKit Review Bot
Comment 8 2012-09-12 15:43:32 PDT
Comment on attachment 163706 [details] Patch Clearing flags on attachment: 163706 Committed r128374: <http://trac.webkit.org/changeset/128374>
WebKit Review Bot
Comment 9 2012-09-12 15:43:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.