Bug 96560

Summary: [v8] document.getCSSCanvasContext doesn't need to be custom
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gyuyoung.kim, haraken, japhet, ojan, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Adam Barth 2012-09-12 14:38:58 PDT 
[v8] document.getCSSCanvasContext doesn't need to be custom
Comment 1 Adam Barth 2012-09-12 14:39:54 PDT 
Created attachment 163695 [details]
Patch
Comment 2 Adam Barth 2012-09-12 14:40:57 PDT 
Created attachment 163698 [details]
Patch
Comment 3 Eric Seidel (no email) 2012-09-12 14:43:43 PDT 
Comment on attachment 163698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163698&action=review

> Source/WebCore/bindings/v8/custom/V8CanvasRenderingContextCustom.cpp:45
> +        return v8NullWithCheck(isolate);

This is now null instead of undefined.  Do we care?
Comment 4 Adam Barth 2012-09-12 14:55:04 PDT 
(In reply to comment #3)
> (From update of attachment 163698 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=163698&action=review
> 
> > Source/WebCore/bindings/v8/custom/V8CanvasRenderingContextCustom.cpp:45
> > +        return v8NullWithCheck(isolate);
> 
> This is now null instead of undefined.  Do we care?

I don't really care, but I'll add a test just for you.
Comment 5 Adam Barth 2012-09-12 15:00:48 PDT 
Created attachment 163706 [details]
Patch
Comment 6 Adam Barth 2012-09-12 15:00:57 PDT 
Now with test.
Comment 7 Eric Seidel (no email) 2012-09-12 15:03:30 PDT 
Comment on attachment 163706 [details]
Patch

OK.
Comment 8 WebKit Review Bot 2012-09-12 15:43:32 PDT 
Comment on attachment 163706 [details]
Patch

Clearing flags on attachment: 163706

Committed r128374: <http://trac.webkit.org/changeset/128374>
Comment 9 WebKit Review Bot 2012-09-12 15:43:36 PDT 
All reviewed patches have been landed.  Closing bug.