Bug 96538

Summary: IndexedDB: Result of IDBFactory.deleteDatabase() should be undefined, not null
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: WebCore Misc.Assignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dgrogan, tony, webkit.review.bot
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Joshua Bell 2012-09-12 11:58:52 PDT 
The spec http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html sayeth:

deleteDatabase
...
"If the steps above are successful, the implementation must set the result of the request to undefined..."

Currently, in WebKit, we return null:

void IDBDatabaseBackendImpl::deleteDatabase(PassRefPtr<IDBCallbacks> prpCallbacks)
{
...
    callbacks->onSuccess(SerializedScriptValue::nullValue());
}
Comment 1 Joshua Bell 2012-09-12 11:59:16 PDT 
Found c/o the W3C test submission:

http://w3c-test.org/webapps/IndexedDB/tests/submissions/Microsoft/idbfactory_deleteDatabase2.htm
Comment 2 Joshua Bell 2012-09-12 13:01:28 PDT 
Created attachment 163675 [details]
Patch
Comment 3 Joshua Bell 2012-09-12 13:01:55 PDT 
dgrogan@ - can you take a look?
Comment 4 David Grogan 2012-09-12 13:05:03 PDT 
Comment on attachment 163675 [details]
Patch

LGTM
Comment 5 Joshua Bell 2012-09-12 13:12:18 PDT 
easy one - tony@ - r? cq?
Comment 6 Joshua Bell 2012-09-17 09:19:46 PDT 
tony@ r? cq?
Comment 7 WebKit Review Bot 2012-09-17 12:59:48 PDT 
Comment on attachment 163675 [details]
Patch

Clearing flags on attachment: 163675

Committed r128795: <http://trac.webkit.org/changeset/128795>
Comment 8 WebKit Review Bot 2012-09-17 12:59:51 PDT 
All reviewed patches have been landed.  Closing bug.