Bug 96521

Summary: [Chromium] Remove unused popupsAllowed function from PlatformSupport
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch none

Mark Pilgrim (Google)
Reported 2012-09-12 08:16:44 PDT
[Chromium] Remove unused popupsAllowed function from PlatformSupport
Attachments
Patch (4.10 KB, patch)
2012-09-12 08:18 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Patch (3.49 KB, patch)
2012-09-19 09:23 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2012-09-12 08:18:15 PDT
Created attachment 163635 [details] Patch
Mark Pilgrim (Google)
Comment 2 2012-09-12 08:18:53 PDT
Comment on attachment 163635 [details] Patch Any reason not to do this?
Eric Seidel (no email)
Comment 3 2012-09-12 10:33:53 PDT
Comment on attachment 163635 [details] Patch Maybe you should move the FIXME as well. :)
Mark Pilgrim (Google)
Comment 4 2012-09-19 09:23:10 PDT
Created attachment 164748 [details] Patch
Mark Pilgrim (Google)
Comment 5 2012-09-19 09:23:56 PDT
Comment on attachment 164748 [details] Patch Nits addressed. Also removed some spurious whitespace-only patch lines from previous patch that were due to borked editor settings on my local machine (now fixed).
WebKit Review Bot
Comment 6 2012-09-19 10:45:31 PDT
Comment on attachment 164748 [details] Patch Clearing flags on attachment: 164748 Committed r129016: <http://trac.webkit.org/changeset/129016>
WebKit Review Bot
Comment 7 2012-09-19 10:45:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.