Bug 96521

Summary: [Chromium] Remove unused popupsAllowed function from PlatformSupport
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: WebKit Misc.Assignee: Mark Pilgrim (Google) <pilgrim>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, fishd, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82948    
Attachments:
Description Flags
Patch
none
Patch none

Description Mark Pilgrim (Google) 2012-09-12 08:16:44 PDT 
[Chromium] Remove unused popupsAllowed function from PlatformSupport
Comment 1 Mark Pilgrim (Google) 2012-09-12 08:18:15 PDT 
Created attachment 163635 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2012-09-12 08:18:53 PDT 
Comment on attachment 163635 [details]
Patch

Any reason not to do this?
Comment 3 Eric Seidel (no email) 2012-09-12 10:33:53 PDT 
Comment on attachment 163635 [details]
Patch

Maybe you should move the FIXME as well. :)
Comment 4 Mark Pilgrim (Google) 2012-09-19 09:23:10 PDT 
Created attachment 164748 [details]
Patch
Comment 5 Mark Pilgrim (Google) 2012-09-19 09:23:56 PDT 
Comment on attachment 164748 [details]
Patch

Nits addressed. Also removed some spurious whitespace-only patch lines from previous patch that were due to borked editor settings on my local machine (now fixed).
Comment 6 WebKit Review Bot 2012-09-19 10:45:31 PDT 
Comment on attachment 164748 [details]
Patch

Clearing flags on attachment: 164748

Committed r129016: <http://trac.webkit.org/changeset/129016>
Comment 7 WebKit Review Bot 2012-09-19 10:45:34 PDT 
All reviewed patches have been landed.  Closing bug.