Summary: | Web Inspector: NMI: migrate core instrumentation code to WTF namespace | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Ilya Tikhonovsky <loislo> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, alph, apavlov, benjamin, bweinstein, cmarcelo, eric.carlson, eric, feature-media-reviews, gustavo, haraken, japhet, joepeck, keishi, loislo, macpherson, menard, pfeldman, philn, pmuellr, rik, timothy, webkit.review.bot, xan.lopez, yurys | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2012-09-12 07:20:46 PDT
Created attachment 163623 [details]
Patch
Comment on attachment 163623 [details] Patch Attachment 163623 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13824725 Comment on attachment 163623 [details] Patch Attachment 163623 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13833405 Comment on attachment 163623 [details] Patch Attachment 163623 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13835229 Created attachment 163634 [details]
Patch
Comment on attachment 163634 [details] Patch Attachment 163634 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13821837 (In reply to comment #6) > (From update of attachment 163634 [details]) > Attachment 163634 [details] did not pass qt-wk2-ews (qt): > Output: http://queues.webkit.org/results/13821837 Looks like problem with dependency tracking. Comment on attachment 163634 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163634&action=review > Source/WebCore/bindings/js/ScriptProfiler.cpp:41 > +#include <wtf/Forward.h> You already included it in the header file. > Source/WebCore/css/MediaQuery.h:-39 > -class MemoryObjectInfo; How does this class declaration come here now? (In reply to comment #8) > (From update of attachment 163634 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163634&action=review > > > Source/WebCore/bindings/js/ScriptProfiler.cpp:41 > > +#include <wtf/Forward.h> > > You already included it in the header file. > > > Source/WebCore/css/MediaQuery.h:-39 > > -class MemoryObjectInfo; > > How does this class declaration come here now? It comes from wtf/Forward.h Comment on attachment 163634 [details] Patch Attachment 163634 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13839196 Created attachment 163776 [details]
Patch
Created attachment 163784 [details]
with fix for mac build
Comment on attachment 163784 [details] with fix for mac build Attachment 163784 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13824984 (In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 163634 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=163634&action=review > > > > > Source/WebCore/bindings/js/ScriptProfiler.cpp:41 > > > +#include <wtf/Forward.h> > > > > You already included it in the header file. > > > > > Source/WebCore/css/MediaQuery.h:-39 > > > -class MemoryObjectInfo; > > > > How does this class declaration come here now? > > It comes from wtf/Forward.h Still don't see it. (In reply to comment #14) > (In reply to comment #9) > > (In reply to comment #8) > > > (From update of attachment 163634 [details] [details] [details]) > > > View in context: https://bugs.webkit.org/attachment.cgi?id=163634&action=review > > > > > > > Source/WebCore/bindings/js/ScriptProfiler.cpp:41 > > > > +#include <wtf/Forward.h> > > > > > > You already included it in the header file. > > > > > > > Source/WebCore/css/MediaQuery.h:-39 > > > > -class MemoryObjectInfo; > > > > > > How does this class declaration come here now? > > > > It comes from wtf/Forward.h > > Still don't see it. I found that it is including indirectly via wtf/WTFString.h -> wtf/StringImpl.h -> wtf/Forward.h (In reply to comment #15) > (In reply to comment #14) > > (In reply to comment #9) > > > (In reply to comment #8) > > > > (From update of attachment 163634 [details] [details] [details] [details]) > > > > View in context: https://bugs.webkit.org/attachment.cgi?id=163634&action=review > > > > > > > > > Source/WebCore/bindings/js/ScriptProfiler.cpp:41 > > > > > +#include <wtf/Forward.h> > > > > > > > > You already included it in the header file. > > > > > > > > > Source/WebCore/css/MediaQuery.h:-39 > > > > > -class MemoryObjectInfo; > > > > > > > > How does this class declaration come here now? > > > > > > It comes from wtf/Forward.h > > > > Still don't see it. > > I found that it is including indirectly via > wtf/WTFString.h -> wtf/StringImpl.h -> wtf/Forward.h I think I can remove this include from StringImpl.h Looks like it is using only for "template <typename T> class StringBuffer;" But this change will affect toщ much cpp files so I'd like to do this in a separate patch. Committed r128418: <http://trac.webkit.org/changeset/128418> |