Bug 96510

Summary:

Web Inspector: [TextEditor] Line numbers out of sync after closing breakpoint condition editor

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Adaikin <aandrey>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aandrey, apavlov, bweinstein, joepeck, keishi, loislo, mibalan, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none

Alexander Pavlov (apavlov)

Reported 2012-09-12 07:10:38 PDT

1. On a breakpoint, invoke the "Edit Breakpoint..." context menu action 2. Click outside the editor popup so that it will close Observe the gap below the breakpoint line number in the line numbers gutter.

Attachments
Patch (7.88 KB, patch) 2012-09-21 02:37 PDT, Andrey Adaikin	no flags	Details Formatted Diff Diff
Patch (2.22 KB, patch) 2012-09-21 03:08 PDT, Andrey Adaikin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mihai Balan

Comment 1 2012-09-20 03:40:03 PDT

OK, I'm attempting a fix on this one.

Mihai Balan

Comment 2 2012-09-20 08:15:49 PDT

I have a somewhat related question - why should the change be committed on blur? Because that's how it looks like from the code.

Pavel Feldman

Comment 3 2012-09-21 02:28:46 PDT

I guess adding this._syncDecorationsForLineListener(lineNumber); into WebInspector.TextEditorGutterPanel's add/removeDecoration will fix it.

Andrey Adaikin

Comment 4 2012-09-21 02:37:40 PDT

Created attachment 165095 [details] Patch

Pavel Feldman

Comment 5 2012-09-21 02:46:32 PDT

Comment on attachment 165095 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165095&action=review > Source/WebCore/inspector/front-end/DefaultTextEditor.js:-1072 > - this._textEditor = textEditor; Why did this change? I think you should do rename in a separate patch. > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2549 > + if (this.linesCount === 1) Can we get here otherwise? > Source/WebCore/inspector/front-end/DefaultTextEditor.js:2564 > + if (this.linesCount === 1) ditto

Andrey Adaikin

Comment 6 2012-09-21 03:08:25 PDT

Created attachment 165104 [details] Patch

WebKit Review Bot

Comment 7 2012-09-24 02:41:28 PDT

Comment on attachment 165104 [details] Patch Clearing flags on attachment: 165104 Committed r129339: <http://trac.webkit.org/changeset/129339>

WebKit Review Bot

Comment 8 2012-09-24 02:41:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.