Bug 96479

Summary: [Qt] REGRESSION(r128174,r128179): It broke the --minimal --no-webkit2 build
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Blocker CC: abecsi, hausmann, ossy, vestbo, webkit.review.bot
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 96491    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2012-09-12 01:39:11 PDT
r128174 broke the minimal build and then it seemed r128179 fixed it, but unfortunately it was't true. After a clean build it is still broken. :( --------------------------------------------------------------------------------------------------------------------- generated/JSDOMWindow.cpp: In function ‘JSC::EncodedJSValue WebCore::jsDOMWindowPrototypeFunctionWebkitRequestAnimationFrame(JSC::ExecState*)’: generated/JSDOMWindow.cpp:9610: error: ‘RequestAnimationFrameCallback’ was not declared in this scope generated/JSDOMWindow.cpp:9610: error: template argument 1 is invalid generated/JSDOMWindow.cpp:9610: error: invalid type in declaration before ‘=’ token generated/JSDOMWindow.cpp:9610: error: ‘JSRequestAnimationFrameCallback’ has not been declared generated/JSDOMWindow.cpp:9612: error: ‘class WebCore::DOMWindow’ has no member named ‘webkitRequestAnimationFrame’ generated/JSDOMWindow.cpp: In function ‘JSC::EncodedJSValue WebCore::jsDOMWindowPrototypeFunctionWebkitCancelAnimationFrame(JSC::ExecState*)’: generated/JSDOMWindow.cpp:9630: error: ‘class WebCore::DOMWindow’ has no member named ‘webkitCancelAnimationFrame’ generated/JSDOMWindow.cpp: In function ‘JSC::EncodedJSValue WebCore::jsDOMWindowPrototypeFunctionWebkitCancelRequestAnimationFrame(JSC::ExecState*)’: generated/JSDOMWindow.cpp:9648: error: ‘class WebCore::DOMWindow’ has no member named ‘webkitCancelRequestAnimationFrame’ make[3]: *** [obj/release/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/generated/JSDOMWindow.o] Error 1 make[3]: *** Waiting for unfinished jobs.... Could you check it, please?
Attachments
Patch (1.35 KB, patch)
2012-09-12 04:33 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2012-09-12 03:53:48 PDT
Oops, let me change the title back. The fix requires multiple changes, the RAF=0 part being only _one_ aspect.
Simon Hausmann
Comment 2 2012-09-12 04:33:21 PDT
Created attachment 163581 [details] Patch
Csaba Osztrogonác
Comment 3 2012-09-12 04:37:17 PDT
Comment on attachment 163581 [details] Patch Will it fix --minimal build for WebKit2? (https://bugs.webkit.org/show_bug.cgi?id=93258)
Simon Hausmann
Comment 4 2012-09-12 04:37:36 PDT
Comment on attachment 163581 [details] Patch GRr, wrong bug
Csaba Osztrogonác
Comment 5 2012-09-12 04:47:34 PDT
Our minimal bot (--minimal --no-webkit2 build) is happy now, shouldn't we track fixing --minimal WK2 build in https://bugs.webkit.org/show_bug.cgi?id=93258?
Simon Hausmann
Comment 6 2012-09-12 04:48:35 PDT
(In reply to comment #5) > Our minimal bot (--minimal --no-webkit2 build) is happy now, shouldn't we track > fixing --minimal WK2 build in https://bugs.webkit.org/show_bug.cgi?id=93258? You're right. I'll re-arrange the dependencies :)
Note You need to log in before you can comment on or make changes to this bug.