Bug 96471 – [chromium] When running layout tests on android judge about installation success from adb command exit status

• Component: New Bugs
• Status: RESOLVED WONTFIX

[Egor Pasko]

[chromium] When running layout tests on android judge about installation success from adb command exit status

[Egor Pasko]

Created attachment 163528 [details]
Patch

[Egor Pasko]

Created attachment 163535 [details]
[chromium] When running layout tests on android judge about installation success from adb command exit status

previous patch could not apply

[Peter Beverloo]

Hi Egor,

Thank you for the patch! I tried to see if we could rely on the exit codes, and got the result listed at the bottom of this message. It returned "0" regardless of whether the installation succeeded, so I'm afraid it may not be possible to rely on it being right.

A concern I have is that we need to execute the same command twice in order to get the command's output. This does not reproduce on the bots, and as far as I'm aware it neither reproduces for anyone locally: we've been using this code for quite a while now, and various people have ran layout tests.

Could you emphasize on the set up you have, and the output it produces for that environment? I'm interested in seeing whether we can find a better solution, but would like to understand the situation for that.

---

beverloo /buildbot/WebKit  $ adb install -r out/Release/TestWebKitAPI_apk/TestWebKitAPI-debug.apk 
echo6005 KB/s (10398532 bytes in 1.691s)
	pkg: /data/local/tmp/TestWebKitAPI-debug.apk
Success
beverloo /buildbot/WebKit  $ echo $?
0
beverloo /buildbot/WebKit  $ adb install out/Release/TestWebKitAPI_apk/TestWebKitAPI-debug.apk 
5597 KB/s (10398532 bytes in 1.814s)
	pkg: /data/local/tmp/TestWebKitAPI-debug.apk
Failure [INSTALL_FAILED_ALREADY_EXISTS]
beverloo /buildbot/WebKit  $ echo $?
0

[Egor Pasko]

Peter,

it looks like my version of adb is different, but it appears from the dependency pulled into my tree:
$ which adb
/[...]/clank/external/chrome/third_party/android_tools/sdk//platform-tools/adb

And I never get "Success" or "Failure" in adb's stdout:

$ adb install -r out/Debug/DumpRenderTree_apk/DumpRenderTree-debug.apk; echo $?
4287 KB/s (12481666 bytes in 2.843s)
0

$ adb install out/Debug/DumpRenderTree_apk/DumpRenderTree-debug.apk; echo $?
4343 KB/s (12481666 bytes in 2.806s)
0

$ adb install /does/not/exist; echo $?
can't find '/does/not/exist' to install
1

so my version of adb seems to be less verbose and at the same time correctly sets the exit code. It would be nice to find the cause for such difference.

[Peter Beverloo]

I see. Where did you install ADB from? Are you using a Mac by any chance?

beverloo WebKit (fifo-test-runners) $ adb --version
Android Debug Bridge version 1.0.29

[Egor Pasko]

adb --version 2>&1 | head -1
Android Debug Bridge version 1.0.29

As I wrote (see result of `which adb`), the adb is coming from the Android SDK that is in the chrome tree (pulled via git deps).

Could it be that the environment is set up differently? I am out of ideas.

If there are two valid adb modes with said behavior we would become more careful:
1. check if we encountered "Success" or "Failure" (we are with the "old" adb mode)
2. else judge by the exit code (we are with the adb mode that Egor is having)

I don't like how it looks/reads but really I do not see other ways how this can be transitioned from one mode to another smoothly given the assumption that two modes of adb are correct.

[Egor Pasko]

and it's Linux

[Peter Beverloo]

(In reply to comment #4)
> $ adb install -r out/Debug/DumpRenderTree_apk/DumpRenderTree-debug.apk; echo $?
> 4287 KB/s (12481666 bytes in 2.843s)
> 0
> 
> $ adb install out/Debug/DumpRenderTree_apk/DumpRenderTree-debug.apk; echo $?
> 4343 KB/s (12481666 bytes in 2.806s)
> 0

For clarity: the second install will have failed, as the package was already installed. It should have shown "Failure [INSTALL_FAILED_ALREADY_EXISTS]"...

[Peter Beverloo]

(In reply to comment #6)
> adb --version 2>&1 | head -1
> Android Debug Bridge version 1.0.29
> 
> As I wrote (see result of `which adb`), the adb is coming from the Android SDK that is in the chrome tree (pulled via git deps).
> 
> Could it be that the environment is set up differently? I am out of ideas.
> 
> If there are two valid adb modes with said behavior we would become more careful:
> 1. check if we encountered "Success" or "Failure" (we are with the "old" adb mode)
> 2. else judge by the exit code (we are with the adb mode that Egor is having)
> 
> I don't like how it looks/reads but really I do not see other ways how this can be transitioned from one mode to another smoothly given the assumption that two modes of adb are correct.

I have no idea why this is happening, maybe adb is crashing? Could you try to run adb in gdb to see if you get any crash stacks or other output? It seems very unlikely that ADB has a verbose and non-verbose mode, I fairly sure that's the case.

Other test suites in Chromium also check for "Success" in the command's output, so you should be able to rely on that. I suspect communication with the device may be timing out as well, have you tried reconnecting it, or using a different USB cable?

[Egor Pasko]

(In reply to comment #8)
> (In reply to comment #4)
> > $ adb install -r out/Debug/DumpRenderTree_apk/DumpRenderTree-debug.apk; echo $?
> > 4287 KB/s (12481666 bytes in 2.843s)
> > 0
> > 
> > $ adb install out/Debug/DumpRenderTree_apk/DumpRenderTree-debug.apk; echo $?
> > 4343 KB/s (12481666 bytes in 2.806s)
> > 0
> 
> For clarity: the second install will have failed, as the package was already installed. It should have shown "Failure [INSTALL_FAILED_ALREADY_EXISTS]"...

It does not fail for me, good to know that it should though, thanks!

I looked at strace of the adb command and I see that there is no crash. From the adb server we successfully get the string "4702 KB/s (12481666 bytes in 2.592s" along with a reply "OKAY". Prints the former and exits.

I also looked at the adb server strace, also looks that it works without any exceptions doing:
1. transfer the apk via transport
2. shell:pm install /data/local/tmp/...
3. shell:rm /data/local/tmp/DumpRenderTree...apk
4. gets OKAY as result

maybe I should re-flash the device with some certain firmware?

[Egor Pasko]

found a way to fix it on the side of the device