Bug 96455
| Summary: | run-perf-tests --build-directory shouldn't assume subdirectories. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Stephanie Lewis <slewis> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, dpranke, eric, rniwa, slewis, zoltan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 77037 | ||
Stephanie Lewis
Thanks for adding --build-directory. It would be nice if it didn't assume that there would be subdirectories named Release or Debug. There are other flavors of builds. I'd prefer it to match run-webkit-tests where --root points directly at the folder containing the app and frameworks.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Is your request to add --root? I don't think we should change the semantics of --build-directory as it'll be confusing for run-perf-tests and run-webkit-tests to interpret the same option differently.
Stephanie Lewis
I guess I am. I didn't even realize --build-directory was an option for run-webkit-tests.
Ryosuke Niwa
See https://bugs.webkit.org/show_bug.cgi?id=91890 and http://trac.webkit.org/changeset/123530.
My current plan is to get rid of --build-directory in run-webkit-tests, and then replace --build-directory by --root in run-perf-tests.
We should probably rename --root though... it's such a cryptic name...
Zoltan Horvath
(In reply to comment #3)
> See https://bugs.webkit.org/show_bug.cgi?id=91890 and http://trac.webkit.org/changeset/123530.
>
> My current plan is to get rid of --build-directory in run-webkit-tests, and then replace --build-directory by --root in run-perf-tests.
>
> We should probably rename --root though... it's such a cryptic name...
Now in run-webkit-tests --root is looking for the binary in bin/ directory, it doesn't seem much better than --build-directory.
I support to make these things clear!