Bug 96407

Summary: We should wait longer before killing the PluginProcess
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 andersca: review+

Brady Eidson
Reported 2012-09-11 10:26:06 PDT
We should wait longer before killing the PluginProcess. Firing up a process and loading in the plug-in bundle is an I/O intensive task. Currently we kill the PluginProcess after 15 seconds of inactivity. That's nuts! It should be much longer.
Attachments
Patch v1 (6.89 KB, patch)
2012-09-11 10:35 PDT, Brady Eidson 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2012-09-11 10:26:28 PDT
In radar as <rdar://problem/12067728>
Brady Eidson
Comment 2 2012-09-11 10:35:09 PDT
Created attachment 163399 [details] Patch v1
Anders Carlsson
Comment 3 2012-09-11 10:36:36 PDT
Comment on attachment 163399 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=163399&action=review > Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:51 > +static const double minimumLifetime = 1800; > +static const double shutdownTimeout = 600; Please write these as 30 * 60 and 10 * 60 respectively, that makes it easier to read the timeouts.
Brady Eidson
Comment 4 2012-09-11 10:42:08 PDT
http://trac.webkit.org/changeset/128205
Note You need to log in before you can comment on or make changes to this bug.