Bug 96393 – [Chromium] Make sure that md5sum is only setup on Android.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Philippe Liard]

Previously md5sum was setup in ChromiumAndroidDriver's constructor which is also invoked on non-Android platforms. The following patch moves this logic to _startup_test() which is guaranteed to be invoked only on Android.

[Peter Beverloo]

+ the gardeners.

[Philippe Liard]

Created attachment 163373 [details]
Patch

[Peter Beverloo]

With your patch applied, I'm now getting this assert:

[1189/1616] webkitpy.layout_tests.port.chromium_android_unittest.ChromiumAndroidDriverTest.test_read_prompt failed:    
  Traceback (most recent call last):
    File "/usr/local/google/build/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py", line 243, in test_read_prompt
      self.assertRaises(AssertionError, self.driver._read_prompt, time.time() + 1)
  AssertionError: AssertionError not raised

[Philippe Liard]

Created attachment 163377 [details]
Patch

[Philippe Liard]

I uploaded a new patch. The previous one was incorrect. Let me see if it solves the error in your last message.

[Peter Beverloo]

Ah, the failure is because we're accepting "$" as input now as well, so the mock input on line 242 causes that. Removing lines 242 and 243 of the unit tests should fix that, as we now accept input running as a non-root (i.e. normal) user as well, making the assert invalid.

[Philippe Liard]

Created attachment 163378 [details]
Patch

[Peter Beverloo]

While I'm not thrilled about the name "_setup_md5sum_and_push_data_if_needed", we can address that later. I verified that the latest patch fixes the webkitpy steps.

[Philippe Liard]

Thanks Peter and sorry for the inconvenience! I will send a CL later addressing the _setup_md5sum_and_push_data_if_needed issue.

[WebKit Review Bot]

Comment on attachment 163378 [details]
Patch

Rejecting attachment 163378 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13826288

[Peter Beverloo]

(In reply to comment #10)
> (From update of attachment 163378 [details])
> Rejecting attachment 163378 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1
> 
> ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
> 
> Full output: http://queues.webkit.org/results/13826288

I'll land it manually.

Philippe: be sure to not remove the "Reviewed by (OOPS!)." line from your CLs :-).

[Philippe Liard]

Ah, sorry :) Thanks for the tip and landing it.

[Peter Beverloo]

Committed r128194: <http://trac.webkit.org/changeset/128194>

[Roger Fong]

Hello, 
I get the following error output for this test on Windows port:

[439/1585] webkitpy.layout_tests.port.chromium_android_unittest.ChromiumAndroidDriverTest.test_command_from_driver_input failed:
  Traceback (most recent call last):
    File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py", line 247, in test_command_from_driver_input
      self.assertEquals(self.driver._command_from_driver_input(driver_input), expected_command)
  AssertionError: "C:\\cygwin\\mock-checkout\\LayoutTests\\foo\\bar\\test.html'--pixel-test'checksum\n" != "/data/local/tmp/third_party/WebKit/LayoutTests/foo/bar/test.html'--pixel-test'checksum\n"

Looks like it's related to this checksum stuff somehow?
Thanks

[Roger Fong]

(In reply to comment #14)
> Hello, 
> I get the following error output for this test on Windows port:
> 
> [439/1585] webkitpy.layout_tests.port.chromium_android_unittest.ChromiumAndroidDriverTest.test_command_from_driver_input failed:
>   Traceback (most recent call last):
>     File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py", line 247, in test_command_from_driver_input
>       self.assertEquals(self.driver._command_from_driver_input(driver_input), expected_command)
>   AssertionError: "C:\\cygwin\\mock-checkout\\LayoutTests\\foo\\bar\\test.html'--pixel-test'checksum\n" != "/data/local/tmp/third_party/WebKit/LayoutTests/foo/bar/test.html'--pixel-test'checksum\n"
> 
> Looks like it's related to this checksum stuff somehow?
> Thanks

I have not received any response. Therefore I'm going to skip this part of the test for now and reopen this bug.

[Roger Fong]

Setting bug as unconfirmed

[Roger Fong]

Meh, I'll just make a new bug, that makes more sense

[Roger Fong]

(In reply to comment #17)
> Meh, I'll just make a new bug, that makes more sense

https://bugs.webkit.org/show_bug.cgi?id=98288

[Philippe Liard]

Sorry guys for the late reply, I was traveling. I will look at the issue.

[Roger Fong]

Thanks :)