Bug 96373

Summary: [chromium] consumable user gesture count off for input events
Product: WebKit Reporter: jochen
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

jochen
Reported 2012-09-11 04:14:56 PDT
In http://trac.webkit.org/changeset/65964 a UserGestureIndicator was introduced in chromium's webkit layer for all input events (later restricted to a subset of input events such as clicks). But even with the restriction, this still creates two consumable gestures (there's also one in WebCore/page/EventHandler for mouse events. I guess initially this was supposed to protect against opening multiple windows from a single user gesture (chrome consumes a user gesture for each new window), however, now a web page can open two windows per event
Attachments
Patch (7.64 KB, patch)
2012-09-11 06:28 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Patch (7.79 KB, patch)
2012-09-11 11:32 PDT, jochen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
jochen
Comment 1 2012-09-11 06:28:38 PDT
Created attachment 163348 [details] Patch
WebKit Review Bot
Comment 2 2012-09-11 06:31:12 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
jochen
Comment 3 2012-09-11 06:34:06 PDT
It seems like the old code can just be removed. I'm currently building on mac to see what wtr does with the test.
jochen
Comment 4 2012-09-11 06:57:57 PDT
Fails on both wk1 and wk2 :-/ Is it preferable to skip the layout test or move to to platform/chromium?
Adam Barth
Comment 5 2012-09-11 09:09:49 PDT
Comment on attachment 163348 [details] Patch I'd put it in platform/chromium because consumable user gestures are only used by chromium.
jochen
Comment 6 2012-09-11 11:32:52 PDT
Created attachment 163411 [details] Patch
jochen
Comment 7 2012-09-11 12:21:49 PDT
Comment on attachment 163411 [details] Patch meh fast/events/popup-blocking-timers.html seems to rely on creating a ton of popups with a single user event I guess I need to rewrite the test to generate an equal amount of clicks.
WebKit Review Bot
Comment 8 2012-09-11 12:31:42 PDT
Comment on attachment 163411 [details] Patch Attachment 163411 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13824370 New failing tests: fast/events/popup-blocking-timers.html
WebKit Review Bot
Comment 9 2012-09-12 00:53:37 PDT
Comment on attachment 163411 [details] Patch Clearing flags on attachment: 163411 Committed r128273: <http://trac.webkit.org/changeset/128273>
WebKit Review Bot
Comment 10 2012-09-12 00:53:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.