Bug 96372

Summary: [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-09-11 04:05:53 PDT
TestRunner needs to implement clearApplicationCacheForOrigin. It is needed by the following test cases: http/tests/appcache/origin-delete.html http/tests/appcache/origin-usage.html
Attachments
Patch (8.81 KB, patch)
2012-09-11 04:10 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-09-11 04:10:29 PDT
Created attachment 163328 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-09-11 04:55:13 PDT
Comment on attachment 163328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163328&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:98 > +WK_EXPORT void WKBundleClearApplicationCacheForOrigin(WKBundleRef bundle, WKStringRef origin); > WK_EXPORT void WKBundleSetAppCacheMaximumSize(WKBundleRef bundle, uint64_t size); > WK_EXPORT uint64_t WKBundleGetAppCacheUsageForOrigin(WKBundleRef bundle, WKStringRef origin); Why are these api's inconsistent? AppCache vs ApplicationCache. That should really be fixed
Chris Dumez
Comment 3 2012-09-11 05:05:10 PDT
(In reply to comment #2) > (From update of attachment 163328 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163328&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:98 > > +WK_EXPORT void WKBundleClearApplicationCacheForOrigin(WKBundleRef bundle, WKStringRef origin); > > WK_EXPORT void WKBundleSetAppCacheMaximumSize(WKBundleRef bundle, uint64_t size); > > WK_EXPORT uint64_t WKBundleGetAppCacheUsageForOrigin(WKBundleRef bundle, WKStringRef origin); > > Why are these api's inconsistent? AppCache vs ApplicationCache. That should really be fixed I agree with you but do you want me to do this in the same patch?
Kenneth Rohde Christiansen
Comment 4 2012-09-11 05:18:09 PDT
Nope, another patch and please make sure that users of these API's are informed... ie add Anders Carlson or Sam Weinig
Chris Dumez
Comment 5 2012-09-11 05:22:51 PDT
(In reply to comment #4) > Nope, another patch and please make sure that users of these API's are informed... ie add Anders Carlson or Sam Weinig Sure. Can I get cq+ for this patch then?
WebKit Review Bot
Comment 6 2012-09-11 05:32:02 PDT
Comment on attachment 163328 [details] Patch Clearing flags on attachment: 163328 Committed r128173: <http://trac.webkit.org/changeset/128173>
WebKit Review Bot
Comment 7 2012-09-11 05:32:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.