Bug 96360

Summary: [Qt] New fast/canvas/canvas-lineDash.html introduced in r128116 fails.
Product: WebKit Reporter: Szilard Ledan <szledan>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: darin, junov, kadam, kkristof, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82560, 87008    

Description Szilard Ledan 2012-09-11 00:30:20 PDT
This test fails on Qt.

fast/canvas/canvas-lineDash.html

--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/canvas/canvas-lineDash-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/canvas/canvas-lineDash-actual.txt 
@@ -17,28 +17,28 @@
 PASS lineDash[1] is 2
 PASS ctx.lineDashOffset is 5
 PASS getPixel(25,10) is [0,255,0,255]
-PASS getPixel(35,10) is [0,0,0,0]
+FAIL getPixel(35,10) should be 0,0,0,0. Was 0,255,0,255.
 PASS getPixel(40,25) is [0,255,0,255]
-PASS getPixel(40,35) is [0,0,0,0]
+FAIL getPixel(40,35) should be 0,0,0,0. Was 0,255,0,255.
 PASS getPixel(25,40) is [0,255,0,255]
-PASS getPixel(15,40) is [0,0,0,0]
+FAIL getPixel(15,40) should be 0,0,0,0. Was 0,255,0,255.
 PASS getPixel(10,25) is [0,255,0,255]
-PASS getPixel(10,15) is [0,0,0,0]
-PASS getPixel(55,10) is [0,0,0,0]
+FAIL getPixel(10,15) should be 0,0,0,0. Was 0,255,0,255.
+FAIL getPixel(55,10) should be 0,0,0,0. Was 0,255,0,255.
 PASS getPixel(65,10) is [0,255,0,255]
-PASS getPixel(80,15) is [0,0,0,0]
+FAIL getPixel(80,15) should be 0,0,0,0. Was 0,255,0,255.
 PASS getPixel(80,25) is [0,255,0,255]
-PASS getPixel(75,40) is [0,0,0,0]
+FAIL getPixel(75,40) should be 0,0,0,0. Was 0,255,0,255.
 PASS getPixel(65,40) is [0,255,0,255]
-PASS getPixel(50,35) is [0,0,0,0]
+FAIL getPixel(50,35) should be 0,0,0,0. Was 0,255,0,255.
 PASS getPixel(50,25) is [0,255,0,255]
-PASS getPixel(95,10) is [0,0,0,0]
+FAIL getPixel(95,10) should be 0,0,0,0. Was 0,255,0,255.
 PASS getPixel(105,10) is [0,255,0,255]
-PASS getPixel(120,15) is [0,0,0,0]
+FAIL getPixel(120,15) should be 0,0,0,0. Was 0,255,0,255.
 PASS getPixel(120,25) is [0,255,0,255]
-PASS getPixel(115,40) is [0,0,0,0]
+FAIL getPixel(115,40) should be 0,0,0,0. Was 0,255,0,255.
 PASS getPixel(105,40) is [0,255,0,255]
-PASS getPixel(90,35) is [0,0,0,0]
+FAIL getPixel(90,35) should be 0,0,0,0. Was 0,255,0,255.
 PASS getPixel(90,25) is [0,255,0,255]
 PASS successfullyParsed is true
Comment 1 Csaba Osztrogonác 2012-09-11 03:49:55 PDT
We skipped it on Qt to paint the bot green - https://trac.webkit.org/changeset/128167

Please unskip it with the proper fix.
Comment 2 Justin Novosad 2012-09-11 06:39:27 PDT
(In reply to comment #1)
> We skipped it on Qt to paint the bot green - https://trac.webkit.org/changeset/128167
> 
> Please unskip it with the proper fix.

These failures are pixel discrepancies in the line dash pattern.  Most probable cause is that GraphicsContext::setLineDash implementation in GraphicsContextQt.cpp does not work as expected.  The failing subtest has to do with a non-zero dash offset.  That is probably what is causing trouble.  I know nothing about drawing with Qt but I suspect the call to QPen::setDashOffset may be the culprit here.  Perhaps an issue with the scale or sign of the offset?
Comment 3 Jocelyn Turcotte 2014-02-03 03:22:30 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.