Bug 96338
| Summary: | Drive SVG animations via requestAnimationFrame | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Philip Rogers <pdr> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | anilsson, krit, zimmermann |
| Priority: | P2 | ||
| Version: | 420+ | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Philip Rogers
We currently hook SVG animations on a 40fps timer:
SMILTimeContainer.cpp, static const double animationFrameDelay = 0.025.
If we hooked up to requestAnimationFrame, we could draw at 60fps and not slow foreground pages down when we are a background tab.
@Niko, @Dirk, can you think of any reason this wouldn't work?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Dirk Schulze
Adding Arvid to this bug report. As far as I understood, he was working on that before. Maybe he can give more input of even add a patch :)
Dirk Schulze
(In reply to comment #1)
> Adding Arvid to this bug report. As far as I understood, he was working on that before. Maybe he can give more input of even add a patch :)
Just as a general comment: Yes!!! It should work with requestAnimationFrame!
Nikolas Zimmermann
I have an unfinished branch which unifies SMIL CSS animations with our existing CSS Animations/Transitions frameworks. I think some bugs were left to fix. Would this could help you?
Arvid Nilsson
(In reply to comment #3)
> I have an unfinished branch which unifies SMIL CSS animations with our existing CSS Animations/Transitions frameworks. I think some bugs were left to fix. Would this could help you?
I was actually investigating whether I could move to RAF instead of the CSS animation timer in WebCore. At that time, The AnimationController was also using a 40 fps timer. I haven't looked into SVG animations, but it sounds very similar.