Bug 96336

Summary: [V8] createFunctionOnlyCallback should be in V8Callback.h with the other callback functions
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-09-10 16:43:27 PDT
[V8] createFunctionOnlyCallback should be in V8Callback.h with the other callback functions
Attachments
Patch (6.17 KB, patch)
2012-09-10 16:44 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-09-10 16:44:29 PDT
Created attachment 163244 [details] Patch
Kentaro Hara
Comment 2 2012-09-10 16:45:47 PDT
Comment on attachment 163244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163244&action=review > Source/WebCore/ChangeLog:9 > + setTypeMismatchException because we no longer have a header inclusion Good refactoring. I've wanted to remove it for months:)
WebKit Review Bot
Comment 3 2012-09-10 17:40:51 PDT
Comment on attachment 163244 [details] Patch Clearing flags on attachment: 163244 Committed r128135: <http://trac.webkit.org/changeset/128135>
WebKit Review Bot
Comment 4 2012-09-10 17:40:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.