Bug 96329

Summary: Refactor computePercentageLogicalHeight to simplify the logic a bit
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+, webkit.review.bot: commit-queue-

Ojan Vafai
Reported 2012-09-10 15:14:23 PDT
Refactor computePercentageLogicalHeight to simplify the logic a bit
Attachments
Patch (4.50 KB, patch)
2012-09-10 15:14 PDT, Ojan Vafai 		tony: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-09-10 15:14:55 PDT
Created attachment 163223 [details] Patch
WebKit Review Bot
Comment 2 2012-09-10 17:22:47 PDT
Comment on attachment 163223 [details] Patch Rejecting attachment 163223 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 154697 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 154697. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13804769
Ojan Vafai
Comment 3 2012-09-11 12:05:11 PDT
Committed r128215: <http://trac.webkit.org/changeset/128215>
Note You need to log in before you can comment on or make changes to this bug.