Summary: | [EFL] Unskip test cases passing reliably on the bots | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebKit EFL | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | d-r, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 96205 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Chris Dumez
2012-09-09 05:44:07 PDT
Created attachment 162992 [details]
Patch
Could someone please cq+ ?
Attachment 162992 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1
LayoutTests/platform/efl-wk1/TestExpectations:1: No port uses path LayoutTests/platform/efl-wk1/TestExpectations for test_expectations [test/expectations] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Style error is a false warning. Fixing the style checker in Bug 96205. Comment on attachment 162992 [details] Patch Rejecting attachment 162992 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ' 50>At revision 154697. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... LayoutTests/platform/efl-wk1/TestExpectations:1: No port uses path LayoutTests/platform/efl-wk1/TestExpectations for test_expectations [test/expectations] [5] Total errors found: 1 in 1 files Full output: http://queues.webkit.org/results/13792616 Comment on attachment 162992 [details]
Patch
Setting cq flag again since the style error is a false warning (addressed in a separate bug).
Comment on attachment 162992 [details] Patch Rejecting attachment 162992 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ' 41>At revision 151890. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... LayoutTests/platform/efl-wk1/TestExpectations:1: No port uses path LayoutTests/platform/efl-wk1/TestExpectations for test_expectations [test/expectations] [5] Total errors found: 1 in 1 files Full output: http://queues.webkit.org/results/13800469 Comment on attachment 162992 [details] Patch Clearing flags on attachment: 162992 Committed r127982: <http://trac.webkit.org/changeset/127982> All reviewed patches have been landed. Closing bug. |