Bug 96204

Summary: [EFL] Unskip test cases passing reliably on the bots
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: d-r, gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 96205    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2012-09-09 05:44:07 PDT
We have several test cases passing reliably on the bots, we should update the TestExpectations files.
Attachments
Patch (3.75 KB, patch)
2012-09-09 06:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2012-09-09 06:29:22 PDT
Created attachment 162992 [details] Patch Could someone please cq+ ?
WebKit Review Bot
Comment 2 2012-09-09 06:32:00 PDT
Attachment 162992 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/platform/efl-wk1/TestExpectations:1: No port uses path LayoutTests/platform/efl-wk1/TestExpectations for test_expectations [test/expectations] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 3 2012-09-09 06:41:25 PDT
Style error is a false warning. Fixing the style checker in Bug 96205.
WebKit Review Bot
Comment 4 2012-09-09 07:06:43 PDT
Comment on attachment 162992 [details] Patch Rejecting attachment 162992 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ' 50>At revision 154697. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... LayoutTests/platform/efl-wk1/TestExpectations:1: No port uses path LayoutTests/platform/efl-wk1/TestExpectations for test_expectations [test/expectations] [5] Total errors found: 1 in 1 files Full output: http://queues.webkit.org/results/13792616
Chris Dumez
Comment 5 2012-09-09 07:10:20 PDT
Comment on attachment 162992 [details] Patch Setting cq flag again since the style error is a false warning (addressed in a separate bug).
WebKit Review Bot
Comment 6 2012-09-09 07:19:46 PDT
Comment on attachment 162992 [details] Patch Rejecting attachment 162992 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ' 41>At revision 151890. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... LayoutTests/platform/efl-wk1/TestExpectations:1: No port uses path LayoutTests/platform/efl-wk1/TestExpectations for test_expectations [test/expectations] [5] Total errors found: 1 in 1 files Full output: http://queues.webkit.org/results/13800469
Raphael Kubo da Costa (:rakuco)
Comment 7 2012-09-09 07:37:46 PDT
Comment on attachment 162992 [details] Patch Clearing flags on attachment: 162992 Committed r127982: <http://trac.webkit.org/changeset/127982>
Raphael Kubo da Costa (:rakuco)
Comment 8 2012-09-09 07:38:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.