Summary: | [V8] convertEventTargetToV8Object doesn't need to be overloaded | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | eric, haraken, jamesr, japhet, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 96217 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Adam Barth
2012-09-09 00:03:47 PDT
Created attachment 162981 [details]
Patch
Comment on attachment 162981 [details]
Patch
LGTM
Comment on attachment 162981 [details] Patch Clearing flags on attachment: 162981 Committed r127979: <http://trac.webkit.org/changeset/127979> All reviewed patches have been landed. Closing bug. I believe this broke the webkit win bot: 2>C:\b\build\slave\webkit-win-latest-rel\build\src\build\Release\obj\global_intermediate\webcore\bindings/V8Event.cpp(55):error C2784: 'T *WTF::getPtr(const WTF::PassOwnPtr<T> &)' : could not deduce template argument for 'const WTF::PassOwnPtr<T> &' from 'WebCore::EventTarget *' 2> C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/PassOwnPtr.h(160) : see declaration of 'WTF::getPtr' 2>C:\b\build\slave\webkit-win-latest-rel\build\src\build\Release\obj\global_intermediate\webcore\bindings/V8Event.cpp(55):error C2784: 'T *WTF::getPtr(const WTF::RefPtr<T> &)' : could not deduce template argument for 'const WTF::RefPtr<T> &' from 'WebCore::EventTarget *' 2> C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/RefPtr.h(196) : see declaration of 'WTF::getPtr' 2>C:\b\build\slave\webkit-win-latest-rel\build\src\build\Release\obj\global_intermediate\webcore\bindings/V8Event.cpp(55):error C2784: 'T *WTF::getPtr(const WTF::PassRefPtr<T> &)' : could not deduce template argument for 'const WTF::PassRefPtr<T> &' from 'WebCore::EventTarget *' 2> C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/PassRefPtr.h(176) : see declaration of 'WTF::getPtr' 2>C:\b\build\slave\webkit-win-latest-rel\build\src\build\Release\obj\global_intermediate\webcore\bindings/V8Event.cpp(55):error C2784: 'OwnPtr<T>::PtrType WTF::getPtr(const WTF::OwnPtr<T> &)' : could not deduce template argument for 'const WTF::OwnPtr<T> &' from 'WebCore::EventTarget *' 2> C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WTF\wtf/OwnPtr.h(160) : see declaration of 'WTF::getPtr' 2>C:\b\build\slave\webkit-win-latest-rel\build\src\build\Release\obj\global_intermediate\webcore\bindings/V8Event.cpp(62):error C2784: 'T *WTF::getPtr(const WTF::PassOwnPtr<T> &)' : could not deduce template argument for 'const WTF::PassOwnPtr<T> &' from 'WebCore::EventTarget *' 2 etc See http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20Builder/builds/29656/steps/compile/logs/stdio#error1 Linux as well, I think: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%2032/builds/23571/steps/compile/logs/stdio In file included from out/Release/obj/gen/webkit/bindings/V8DerivedSources18.cpp:35: out/Release/obj/gen/webcore/bindings/V8Event.cpp: In function 'v8::Handle<v8::Value> WebCore::EventV8Internal::targetAttrGetter(v8::Local<v8::String>, const v8::AccessorInfo&)': out/Release/obj/gen/webcore/bindings/V8Event.cpp:55:error: no matching function for call to 'getPtr(WebCore::EventTarget*)' I think I'll roll out to get the bots running tests again Interestingly, amongst our linux bots http://build.webkit.org/builders/Chromium%20Linux%20Release is green and has been, but http://build.chromium.org/p/chromium.webkit/waterfall?builder=Webkit+Linux+32 and http://build.chromium.org/p/chromium.webkit/waterfall?builder=Linux+Valgrind are both compile broken. Maybe there's some DEPS issue? For windows the build.webkit.org bot is broken the same way as all the build.chromium.org canaries. |