Summary: | Web Inspector: Set focus on the ExtensionPanel's iframe when it is selected | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | johnjbarton <johnjbarton> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, caseq, cdumez, joepeck, keishi, loislo, ossy, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 97077, 97084 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
johnjbarton
2012-09-07 14:16:39 PDT
Created attachment 162870 [details]
Patch
A different solution would store the extensionView on |this|, eg this._extensionView, then define ExtensionPanel.defaultFocusedElement() to return this._extensionView.defaultFocusedElement(). However the origin impl chose not to store the extensionView and perhaps there was a reason. Comment on attachment 162870 [details]
Patch
LGTM. vsevik, could you please review this?
Comment on attachment 162870 [details] Patch Clearing flags on attachment: 162870 Committed r128910: <http://trac.webkit.org/changeset/128910> All reviewed patches have been landed. Closing bug. (In reply to comment #4) > (From update of attachment 162870 [details]) > Clearing flags on attachment: 162870 > > Committed r128910: <http://trac.webkit.org/changeset/128910> The new inspector/extensions/extensions-panel.html fails on Qt and EFL: --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-actual.txt @@ -22,7 +22,7 @@ show : <function> } Panel shown -focused: true +focused: false Extension panel size correct RUNNING TEST: extension_testSearch Panel hidden Could you check it, please? (In reply to comment #6) > (In reply to comment #4) > > (From update of attachment 162870 [details] [details]) > > Clearing flags on attachment: 162870 > > > > Committed r128910: <http://trac.webkit.org/changeset/128910> > > The new inspector/extensions/extensions-panel.html fails on Qt and EFL: > --- /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-expected.txt > +++ /ramdisk/qt-linux-64-release/build/layout-test-results/inspector/extensions/extensions-panel-actual.txt > @@ -22,7 +22,7 @@ > show : <function> > } > Panel shown > -focused: true > +focused: false > Extension panel size correct > RUNNING TEST: extension_testSearch > Panel hidden > > > Could you check it, please? I'm uncertain who you are asking; if your are asking me I don't know how to check it. Do these platforms have different focus behavior? I don't know anything about this test. But I'm sure it is a regression caused by http://trac.webkit.org/changeset/128910 |