Summary: | [V8] DOM wrapper creation involves a bunch of sketchy code related to finding the Frame | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | eric, haraken, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 96154, 96174 | ||||||||||||||
Bug Blocks: | 96038 | ||||||||||||||
Attachments: |
|
Description
Adam Barth
2012-09-07 14:09:36 PDT
Created attachment 162866 [details]
Work in progress
This patch works great, it's just slow. == Before == Running Bindings/first-child.html (1 of 1) DESCRIPTION: This benchmark covers 'firstChild', 'lastChild', 'nextSibling' and 'previousSibling' in Dromaeo/dom-traverse.html, and other DOM attributes that return a Node object. RESULT Bindings: first-child= 791.916889238 runs/s median= 793.650793651 runs/s, stdev= 6.87585793436 runs/s, min= 781.25 runs/s, max= 803.011292346 runs/s RESULT Bindings: first-child: JSHeap= 1329937.6 bytes median= 1326148.0 bytes, stdev= 12365.9021765 bytes, min= 1319928.0 bytes, max= 1367472.0 bytes RESULT Bindings: first-child: Malloc= 0.0 bytes median= 0.0 bytes, stdev= 0.0 bytes, min= 0.0 bytes, max= 0.0 bytes == After == Running Bindings/first-child.html (1 of 1) DESCRIPTION: This benchmark covers 'firstChild', 'lastChild', 'nextSibling' and 'previousSibling' in Dromaeo/dom-traverse.html, and other DOM attributes that return a Node object. RESULT Bindings: first-child= 365.905414836 runs/s median= 369.393139842 runs/s, stdev= 10.5470471025 runs/s, min= 325.814536341 runs/s, max= 372.836218375 runs/s RESULT Bindings: first-child: JSHeap= 1329978.4 bytes median= 1326000.0 bytes, stdev= 12336.8814471 bytes, min= 1319856.0 bytes, max= 1367488.0 bytes RESULT Bindings: first-child: Malloc= 0.0 bytes median= 0.0 bytes, stdev= 0.0 bytes, min= 0.0 bytes, max= 0.0 bytes Created attachment 162897 [details]
Patch
This patch works and is fast, but might be too large to review. Here's the patch broken down into a number of smaller steps: https://github.com/abarth/webkit/compare/master...CreationContext I'll post each step as an individual patch. Created attachment 162900 [details]
Now with test progression
Created attachment 162904 [details]
Patch
Committed r127955: <http://trac.webkit.org/changeset/127955> Re-opened since this is blocked by 96174 Created attachment 162959 [details]
Patch for landing
Comment on attachment 162959 [details] Patch for landing Clearing flags on attachment: 162959 Committed r127972: <http://trac.webkit.org/changeset/127972> All reviewed patches have been landed. Closing bug. |