Bug 96086

Summary: Web Inspector: NMI: remove DataRef instrumentation from the core NMI code.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: alph, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch yurys: review+

Ilya Tikhonovsky
Reported 2012-09-07 02:30:44 PDT
It is a mandatory step before moving core code to WTF.
Attachments
Patch (5.15 KB, patch)
2012-09-07 02:36 PDT, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Patch (5.15 KB, patch)
2012-09-07 02:50 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2012-09-07 02:36:02 PDT
Created attachment 162715 [details] Patch
Yury Semikhatsky
Comment 2 2012-09-07 02:44:59 PDT
Comment on attachment 162715 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162715&action=review > Source/WebCore/dom/MemoryInstrumentation.h:35 > +#include <stdio.h> Remove this.
Ilya Tikhonovsky
Comment 3 2012-09-07 02:50:32 PDT
Created attachment 162718 [details] Patch
Yury Semikhatsky
Comment 4 2012-09-07 05:04:31 PDT
Comment on attachment 162718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162718&action=review > Source/WebCore/dom/MemoryInstrumentation.h:203 > + MemoryClassInfo(MemoryObjectInfo* memoryObjectInfo, const T*, MemoryObjectType objectType = 0, size_t actualSize = 0) objectType = 0 -> objectType = GenericMemoryTypes::Undefined
Ilya Tikhonovsky
Comment 5 2012-09-07 05:10:04 PDT
Committed r127856: <http://trac.webkit.org/changeset/127856>
Note You need to log in before you can comment on or make changes to this bug.