Bug 9606

Summary: REGRESSION: some callers are still using clientX/Y to get pageX/Y
Product: WebKit Reporter: Darin Adler <darin>
Component: DOMAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Major CC: cdumez, ddkilzer, rwlbuis
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch to fix the bad callers ggaren: review+

Darin Adler
Reported 2006-06-26 09:17:55 PDT
The fix for bug 8707 introduced this problem.
Attachments
patch to fix the bad callers (1.66 KB, patch)
2006-06-26 09:20 PDT, Darin Adler 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2006-06-26 09:20:40 PDT
Created attachment 9048 [details] patch to fix the bad callers
Geoffrey Garen
Comment 2 2006-06-26 11:27:38 PDT
Comment on attachment 9048 [details] patch to fix the bad callers r=me
Geoffrey Garen
Comment 3 2006-06-26 11:28:23 PDT
... but can I get a ChangeLog and a testcase?
David Kilzer (:ddkilzer)
Comment 4 2006-06-26 12:41:39 PDT
It appears this was committed as r15047.
Darin Adler
Comment 5 2006-06-26 13:36:24 PDT
Really? No way. Did I do that by accident?
Darin Adler
Comment 6 2006-06-26 13:41:55 PDT
(In reply to comment #4) > It appears this was committed as r15047. No. It's not in yet.
David Kilzer (:ddkilzer)
Comment 7 2006-06-26 15:24:29 PDT
(In reply to comment #6) > (In reply to comment #4) > > It appears this was committed as r15047. > > No. It's not in yet. Sorry. Comments from that commit lead me to believe this bug was fixed.
Darin Adler
Comment 8 2006-06-27 09:47:04 PDT
Test cases for each of these are going to be a pain. Working on them.
Darin Adler
Comment 9 2006-06-27 10:17:25 PDT
Landed two of these fixes with test cases and change log. Committed revision 15052. Still need a test case for the frameset one.
Darin Adler
Comment 10 2006-06-27 10:39:53 PDT
Turns out the frameset one wasn't really a bug -- clientX/Y and pageX/Y will always be the same for framesets. I decided to make the change anyway. Committed revision 15053.
Lucas Forschler
Comment 11 2019-02-06 09:03:51 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.