Bug 96043

Summary: Combine MarkStack and SlotVisitor into single class
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, levin+threading, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mark Hahnenberg
Reported 2012-09-06 17:16:56 PDT
MarkStack and SlotVisitor are pretty much the same thing. We should combine them to make the GC code slightly more sane.
Attachments
Patch (64.24 KB, patch)
2012-09-06 17:31 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (65.00 KB, patch)
2012-09-06 18:08 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (65.05 KB, patch)
2012-09-06 20:34 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2012-09-06 17:31:47 PDT
Created attachment 162629 [details] Patch
WebKit Review Bot
Comment 2 2012-09-06 17:33:21 PDT
Attachment 162629 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1 Source/JavaScriptCore/heap/SlotVisitor.cpp:172: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2012-09-06 17:33:40 PDT
Comment on attachment 162629 [details] Patch r=me
Mark Hahnenberg
Comment 4 2012-09-06 18:08:06 PDT
Created attachment 162635 [details] Patch
WebKit Review Bot
Comment 5 2012-09-06 18:09:46 PDT
Attachment 162635 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1 Source/JavaScriptCore/heap/SlotVisitor.cpp:172: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 6 2012-09-06 19:06:45 PDT
Comment on attachment 162635 [details] Patch Attachment 162635 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13769574
Mark Hahnenberg
Comment 7 2012-09-06 20:34:18 PDT
Created attachment 162661 [details] Patch
WebKit Review Bot
Comment 8 2012-09-06 20:37:40 PDT
Attachment 162661 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1 Source/JavaScriptCore/heap/SlotVisitor.cpp:172: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Hahnenberg
Comment 9 2012-09-10 11:40:46 PDT
Committed r128084: <http://trac.webkit.org/changeset/128084>
Note You need to log in before you can comment on or make changes to this bug.