Bug 96003

Summary: Fix WTF.Lrint on 32-bit platforms
Product: WebKit Reporter: Fady Samuel <fsamuel>
Component: New BugsAssignee: Fady Samuel <fsamuel>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, d-r
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch benjamin: review+, benjamin: commit-queue-

Fady Samuel
Reported 2012-09-06 11:49:16 PDT
Disable WTF.Lrint as it fails on Chromium Win/Mac
Attachments
Patch (1.39 KB, patch)
2012-09-06 11:52 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (1.97 KB, patch)
2012-09-06 12:43 PDT, Fady Samuel 		benjamin: review+
benjamin: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2012-09-06 11:52:04 PDT
Created attachment 162548 [details] Patch
Fady Samuel
Comment 2 2012-09-06 12:43:48 PDT
Created attachment 162559 [details] Patch
Benjamin Poulain
Comment 3 2012-09-06 12:45:22 PDT
Comment on attachment 162559 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162559&action=review > Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:49 > + // Largest double number with 0.5 precision and one halfway rounding case below. > + EXPECT_EQ(lrint(pow(2.0, 52) - 0.5), pow(2.0, 52)); > + EXPECT_EQ(lrint(pow(2.0, 52) - 1.5), pow(2.0, 52) - 2); > + // Smallest double number with 0.5 precision and one halfway rounding case above. > + EXPECT_EQ(lrint(-pow(2.0, 52) + 0.5), -pow(2.0, 52)); > + EXPECT_EQ(lrint(-pow(2.0, 52) + 1.5), -pow(2.0, 52) + 2); Wrong indent.
Benjamin Poulain
Comment 4 2012-09-06 12:50:13 PDT
Committed r127775: <http://trac.webkit.org/changeset/127775>
Note You need to log in before you can comment on or make changes to this bug.