Bug 95985

Summary:

Web Inspector: Migrate FileSystem to async protocol commands.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, tzik, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	apavlov: review+

Vsevolod Vlasov

Reported 2012-09-06 08:14:04 PDT

Migrate FileSystem to async protocol commands.

Attachments
Patch (66.61 KB, patch) 2012-09-06 10:00 PDT, Vsevolod Vlasov	apavlov: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Vsevolod Vlasov

Comment 1 2012-09-06 10:00:01 PDT

Created attachment 162530 [details] Patch

Alexander Pavlov (apavlov)

Comment 2 2012-09-07 04:50:25 PDT

Comment on attachment 162530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162530&action=review > Source/WebCore/inspector/front-end/FileSystemModel.js:169 > + callback(FileError.SECURITY_ERR); optional callback used unconditionally? > Source/WebCore/inspector/front-end/FileSystemModel.js:255 > + callback(FileError.SECURITY_ERR); ditto > Source/WebCore/inspector/front-end/FileSystemModel.js:332 > + * @param {function(number, string=, string=)=} callback param declared as optional but used without any checks in the code > Source/WebCore/inspector/front-end/FileSystemModel.js:387 > + callback(FileError.SECURITY_ERR); ditto

Alexander Pavlov (apavlov)

Comment 3 2012-09-07 04:58:04 PDT

Comment on attachment 162530 [details] Patch r=me Please fix the optional argument usages before landing.

Vsevolod Vlasov

Comment 4 2012-09-07 05:23:33 PDT

Committed r127858: <http://trac.webkit.org/changeset/127858>

Note You need to log in before you can comment on or make changes to this bug.