Bug 95931

Summary: Part 2 of removing PlatformString.h, remove PlatformString.h
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, cmarcelo, danw, eric.carlson, eric, feature-media-reviews, gustavo, gyuyoung.kim, haraken, jamesr, japhet, levin+threading, macpherson, menard, mifenton, mrobinson, noam, rakuco, senorblanco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch abarth: review+

Sam Weinig
Reported 2012-09-05 21:48:32 PDT
Part 2 of removing PlatformString.h, remove PlatformString.h
Attachments
Patch (345.22 KB, patch)
2012-09-05 21:53 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (346.22 KB, patch)
2012-09-05 22:44 PDT, Sam Weinig 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2012-09-05 21:53:34 PDT
Created attachment 162412 [details] Patch
WebKit Review Bot
Comment 2 2012-09-05 21:57:45 PDT
Attachment 162412 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/pango/FontPlatformDataPango.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/qt/FileSystemQt.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/graphics/skia/FontCustomPlatformData.h:43: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/win/WebNotificationCenter.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/loader/cache/CachedResource.h:38: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/text/TextCodecUserDefined.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/qt/LoggingQt.cpp:25: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/graphics/wx/FontPlatformDataWx.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/sql/SQLiteDatabase.h:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/Modules/filesystem/EntrySync.h:40: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/qt/CookieJarQt.cpp:41: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/text/qt/TextCodecQt.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/text/TextCodecLatin1.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/gtk/webkit/webkitwebdatasource.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/win/WebCoreSupport/WebInspectorClient.h:41: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/win/WebIconDatabase.cpp:42: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/xml/XMLSerializer.h:24: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/xml/XMLSerializer.h:24: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/win/WebKitSystemBits.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/text/TextCodecUTF16.cpp:31: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 20 in 526 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2012-09-05 22:35:22 PDT
Comment on attachment 162412 [details] Patch Attachment 162412 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13770215
Sam Weinig
Comment 4 2012-09-05 22:44:22 PDT
Created attachment 162422 [details] Patch
WebKit Review Bot
Comment 5 2012-09-05 22:47:26 PDT
Attachment 162422 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/qt/LoggingQt.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/qt/CookieJarQt.cpp:42: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 526 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 6 2012-09-06 00:14:41 PDT
Comment on attachment 162422 [details] Patch rs=me, assuming it builds :)
Sam Weinig
Comment 7 2012-09-06 10:36:24 PDT
Committed r127757: <http://trac.webkit.org/changeset/127757>
Note You need to log in before you can comment on or make changes to this bug.