Bug 95797

Summary: Remove WTF::String::operator+=
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, eric, kangil.han, lauro.neto, mitz, paroga, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
buildbot: commit-queue-
re-spin none

Adam Barth
Reported 2012-09-04 16:52:18 PDT
Remove WTF::String::operator+=
Attachments
Patch (1.49 KB, patch)
2012-09-04 16:57 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (2.02 KB, patch)
2012-09-05 10:50 PDT, Adam Barth 		buildbot: commit-queue-
DetailsFormatted DiffDiff
re-spin (2.02 KB, patch)
2012-09-05 15:00 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-09-04 16:57:39 PDT
Created attachment 162133 [details] Patch
Eric Seidel (no email)
Comment 2 2012-09-04 17:08:40 PDT
Comment on attachment 162133 [details] Patch This looks great, once the other stuff lands. r- to make the EWS not freak out.
Adam Barth
Comment 3 2012-09-05 10:50:17 PDT
Created attachment 162284 [details] Patch
WebKit Review Bot
Comment 4 2012-09-05 10:53:33 PDT
Attachment 162284 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Pl..." exit_code: 1 Source/WTF/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 5 2012-09-05 10:56:39 PDT
Comment on attachment 162284 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162284&action=review > Source/WTF/wtf/Platform.h:1188 > +#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(WIN) You might want to add a comment above this line which explains what this does and that you want to get off this list. :)
Adam Barth
Comment 6 2012-09-05 10:57:03 PDT
(In reply to comment #5) > (From update of attachment 162284 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162284&action=review > > > Source/WTF/wtf/Platform.h:1188 > > +#if PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(WIN) > > You might want to add a comment above this line which explains what this does and that you want to get off this list. :) Will do.
Benjamin Poulain
Comment 7 2012-09-05 11:02:09 PDT
Looks like I mixed my branches yesterday. I'll make one more patch for Mac. I do that ASAP.
Adam Barth
Comment 8 2012-09-05 11:10:04 PDT
(In reply to comment #7) > Looks like I mixed my branches yesterday. I'll make one more patch for Mac. I do that ASAP. Thanks!
Build Bot
Comment 9 2012-09-05 11:40:34 PDT
Comment on attachment 162284 [details] Patch Attachment 162284 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13765295
Benjamin Poulain
Comment 10 2012-09-05 12:02:09 PDT
(In reply to comment #9) > (From update of attachment 162284 [details]) > Attachment 162284 [details] did not pass mac-ews (mac): > Output: http://queues.webkit.org/results/13765295 My bad, I messed up yesterday. Here is the followup fix: https://bugs.webkit.org/show_bug.cgi?id=95880
Gyuyoung Kim
Comment 11 2012-09-05 12:11:48 PDT
Comment on attachment 162284 [details] Patch Attachment 162284 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13765304
Adam Barth
Comment 12 2012-09-05 13:42:25 PDT
@kangil: Thoughts on the EFL EWS failure?
Lauro Moura Maranhao Neto
Comment 13 2012-09-05 14:26:48 PDT
(In reply to comment #12) > @kangil: Thoughts on the EFL EWS failure? Failed on WebInspectorProxy, alread covered by Benjamin in https://bugs.webkit.org/show_bug.cgi?id=95880
Adam Barth
Comment 14 2012-09-05 14:59:44 PDT
Ok. Sounds like I should re-upload this patch and try again.
Adam Barth
Comment 15 2012-09-05 15:00:22 PDT
Created attachment 162344 [details] re-spin
WebKit Review Bot
Comment 16 2012-09-05 15:03:19 PDT
Attachment 162344 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Pl..." exit_code: 1 Source/WTF/ChangeLog:13: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 17 2012-09-06 00:13:16 PDT
Thanks for the review!
Adam Barth
Comment 18 2012-09-06 00:20:29 PDT
Comment on attachment 162344 [details] re-spin Clearing flags on attachment: 162344 Committed r127702: <http://trac.webkit.org/changeset/127702>
Adam Barth
Comment 19 2012-09-06 00:20:32 PDT
All reviewed patches have been landed. Closing bug.
mitz
Comment 20 2012-09-06 00:37:50 PDT
(In reply to comment #18) > (From update of attachment 162344 [details]) > Clearing flags on attachment: 162344 > > Committed r127702: <http://trac.webkit.org/changeset/127702> This broke the debug builds, because Element::formatForDebugger() uses operator+=.
Adam Barth
Comment 21 2012-09-06 00:41:09 PDT
> This broke the debug builds, because Element::formatForDebugger() uses operator+=. Hum... I thought paroga had the debug builds fixed. Maybe his patch didn't land? /me checks.
Patrick R. Gansterer
Comment 22 2012-09-06 00:41:52 PDT
(In reply to comment #21) > > This broke the debug builds, because Element::formatForDebugger() uses operator+=. > > Hum... I thought paroga had the debug builds fixed. Maybe his patch didn't land? /me checks. Patch is at https://bugs.webkit.org/show_bug.cgi?id=95888, but CQ is to slow :-(
Adam Barth
Comment 23 2012-09-06 00:44:54 PDT
> Patch is at https://bugs.webkit.org/show_bug.cgi?id=95888, but CQ is to slow :-( Landing now.
Benjamin Poulain
Comment 24 2012-09-06 01:24:13 PDT
(In reply to comment #23) > > Patch is at https://bugs.webkit.org/show_bug.cgi?id=95888, but CQ is to slow :-( > > Landing now. Yup, that fixed the bots :)
Note You need to log in before you can comment on or make changes to this bug.