Bug 95747

Summary: [BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection
Product: WebKit Reporter: otcheung
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mifenton, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

otcheung
Reported 2012-09-04 07:21:19 PDT
Browser is not sending secured cookies under this scenario: 1) Browser never handled a cookie from a secured protocol (HTTPS) 2) Server adds a "secured" cookie over a non-secured protocol (HTTP) 3) Server asks for secure cookie over a secured protocol (HTTPS)
Attachments
Patch (2.95 KB, patch)
2012-09-04 07:27 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (2.94 KB, patch)
2012-09-04 07:48 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Patch (3.01 KB, patch)
2012-09-04 07:50 PDT, otcheung 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
otcheung
Comment 1 2012-09-04 07:27:48 PDT
Created attachment 162040 [details] Patch
Rob Buis
Comment 2 2012-09-04 07:41:34 PDT
Comment on attachment 162040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162040&action=review Looks good, some stuff to fix still. > Source/WebCore/ChangeLog:2 > + One empty line too many. > Source/WebCore/ChangeLog:11 > + The problem was if the browser has never saved a secure protocol, Can you rephrase this? It seems a bit terse. > Source/WebCore/ChangeLog:18 > + funciton. Typo: function. > Source/WebCore/platform/blackberry/CookieManager.cpp:212 > + // Set the map to the non-secure version, so it'll search the mapping for a secure cookie Lacks period.
otcheung
Comment 3 2012-09-04 07:48:53 PDT
Created attachment 162042 [details] Patch
otcheung
Comment 4 2012-09-04 07:50:44 PDT
Created attachment 162043 [details] Patch
Rob Buis
Comment 5 2012-09-04 07:52:43 PDT
Comment on attachment 162043 [details] Patch Looks good.
WebKit Review Bot
Comment 6 2012-09-04 08:47:03 PDT
Comment on attachment 162043 [details] Patch Clearing flags on attachment: 162043 Committed r127470: <http://trac.webkit.org/changeset/127470>
WebKit Review Bot
Comment 7 2012-09-04 08:47:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.