Bug 9569

Summary:

REGRESSION: Highlighting in native text area encroaches on left/right border

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Forms

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, daniele.metilli, ian, justin.garcia

Priority:

Keywords:

EasyFix, InRadar, Regression

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Screenshot of highlight difference	none
Fix left/rightSelectionOffset to exclude border and padding.	eric: review+

David Kilzer (:ddkilzer)

Reported 2006-06-24 20:28:02 PDT

When highlighting text in the new native text areas, the highlight extends past the left and right borders of the text. It did not used to do this on the old NSView text areas. See attached image for the difference.

Attachments
Screenshot of highlight difference (38.54 KB, image/png) 2006-06-24 20:29 PDT, David Kilzer (:ddkilzer)	no flags	Details
Fix left/rightSelectionOffset to exclude border and padding. (839 bytes, patch) 2007-01-12 00:07 PST, Dave Hyatt	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2006-06-24 20:29:15 PDT

Created attachment 9011 [details] Screenshot of highlight difference

Darin Adler

Comment 2 2006-06-25 17:04:52 PDT

I'm not sure this one is a bug, and possibly not a P1 either. Adele, I'd like you to do some research on what we should do.

Darin Adler

Comment 3 2006-06-25 17:05:36 PDT

But if it is a bug, it's simply setting some CSS properly on the internal elements, I'm almost certain. A margin or padding or something.

Adele Peterson

Comment 4 2006-06-29 11:20:04 PDT

This also happens with contenteditable divs- the selection doesn't respect padding.

Alice Liu

Comment 5 2006-07-05 09:18:49 PDT

<rdar://problem/4613525>

David Kilzer (:ddkilzer)

Comment 6 2006-09-06 04:40:20 PDT

*** Bug 10751 has been marked as a duplicate of this bug. ***

Dave Hyatt

Comment 7 2007-01-12 00:07:10 PST

Created attachment 12379 [details] Fix left/rightSelectionOffset to exclude border and padding. This is an easy one. It was always wrong to go out into the border.

Eric Seidel (no email)

Comment 8 2007-01-12 00:10:13 PST

Comment on attachment 12379 [details] Fix left/rightSelectionOffset to exclude border and padding. Looks good to me. Hyatt assures me there is already a test for this. (pixel mode only).

Dave Hyatt

Comment 9 2007-01-12 00:28:24 PST

Fixed in r18799

Note You need to log in before you can comment on or make changes to this bug.