Summary: | Move AllowShadowContent flag to HitTestRequest | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Allan Sandfeld Jensen <allan.jensen> | ||||
Component: | Layout and Rendering | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, tonikitoo | ||||
Priority: | P2 | ||||||
Version: | 420+ | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 95204 | ||||||
Attachments: |
|
Description
Allan Sandfeld Jensen
2012-09-03 06:42:08 PDT
Created attachment 161919 [details]
Patch
Comment on attachment 161919 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161919&action=review r=me please fix the method name before landing, and maybe strip out the supposedly unrelated change? > Source/WebCore/rendering/HitTestRequest.h:56 > + bool allowShadowContent() const { return m_requestType & AllowShadowContent; } I think it should be allowsShadowContent > Source/WebCore/rendering/HitTestResult.cpp:107 > - , m_region(region) > + , m_region(region ? region : other.m_region) unrelated > Source/WebCore/rendering/HitTestResult.h:58 > - HitTestLocation(const HitTestLocation&, const LayoutSize& offset, RenderRegion*); > + HitTestLocation(const HitTestLocation&, const LayoutSize& offset, RenderRegion* = 0); unrelated? (In reply to comment #2) > (From update of attachment 161919 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=161919&action=review > > r=me > > please fix the method name before landing, and maybe strip out the supposedly unrelated change? > I will. You are right that the two changes were incorrectly included in this patch. Committed r127421: <http://trac.webkit.org/changeset/127421> |