Bug 9568 – assertion failure in Safari after quitting Drosera

• Component: New Bugs
• Status: CLOSED FIXED

[David Kilzer (:ddkilzer)]

I was viewing Attachment 5712 [details] from Bug 6574 with Drosera connected to Safari, then quit Drosera.  This, in turn, caused Safari+WebKit to crash.  I was using a locally-built r15024 WebKit.

Crash log:

Date/Time:      2006-06-24 22:09:24.550 -0500
OS Version:     10.4.6 (Build 8I127)
Report Version: 4

Command: Safari
Path:    /Applications/Safari.app/Contents/MacOS/Safari
Parent:  bash [279]

Version:        2.0.3 (417.9.3)
Build Version:  2
Project Name:   WebBrowser
Source Version: 4170903

PID:    28154
Thread: 0

Exception:  EXC_BAD_ACCESS (0x0001)
Codes:      KERN_INVALID_ADDRESS (0x0001) at 0xbbadbeef

Thread 0 Crashed:
0   com.apple.WebKit         	0x003e1c80 -[WebScriptDebugServer removeListener:] + 104 (WebScriptDebugServer.m:161)
1   libobjc.A.dylib          	0x90a4b1f4 objc_msgSendv + 180
2   com.apple.Foundation     	0x92971c88 -[NSInvocation invoke] + 944
3   com.apple.Foundation     	0x9297174c -[NSConnection dispatchInvocation:] + 252
4   com.apple.Foundation     	0x9296f858 -[NSConnection handleRequest:sequence:] + 988
5   com.apple.Foundation     	0x9296f1cc -[NSConnection handlePortCoder:] + 496
6   com.apple.Foundation     	0x9296ef38 -[NSConcretePortCoder dispatch] + 100
7   com.apple.Foundation     	0x9296e918 __NSFireMachPort + 276
8   com.apple.CoreFoundation 	0x907f1820 __CFMachPortPerform + 176
9   com.apple.CoreFoundation 	0x907f1734 __CFRunLoopDoSource1 + 152
10  com.apple.CoreFoundation 	0x907e3e4c __CFRunLoopRun + 1556
11  com.apple.CoreFoundation 	0x907e347c CFRunLoopRunSpecific + 268
12  com.apple.HIToolbox      	0x9321d980 RunCurrentEventLoopInMode + 264
13  com.apple.HIToolbox      	0x9321d014 ReceiveNextEventCommon + 380
14  com.apple.HIToolbox      	0x9321ce80 BlockUntilNextEventMatchingListInMode + 96
15  com.apple.AppKit         	0x9371fe84 _DPSNextEvent + 384
16  com.apple.AppKit         	0x9371fb48 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 116
17  com.apple.Safari         	0x00006df4 0x1000 + 24052
18  com.apple.AppKit         	0x9371c08c -[NSApplication run] + 472
19  com.apple.AppKit         	0x9380cbfc NSApplicationMain + 452
20  com.apple.Safari         	0x0005cb98 0x1000 + 375704
21  com.apple.Safari         	0x0005ca40 0x1000 + 375360  

[David Kilzer (:ddkilzer)]

In my debug build, there was an assertion failure (which caused the crash):

ASSERTION FAILED: listenerCount >= 1 (/Users/ddkilzer/Projects/Cocoa/WebKit/WebKit/DefaultDelegates/WebScriptDebugServer.m:161 -[WebScriptDebugServer removeListener:])

[Timothy Hatcher]

Created attachment 9030 [details]
Fix

        Call switchToServerNamed:nil and not removeLister to make sure
        the server object is set to nil to prevent further removeListener calls.

        * Drosera/DebuggerDocument.m:
        (-[DebuggerDocument applicationTerminating:]):

[Darin Adler]

Comment on attachment 9030 [details]
Fix

OK, r=me.

[Timothy Hatcher]

Landed in r15042.

[Timothy Hatcher]

Closing since Drosera has been replaced by the new Web Inspector debugger. Moving to the New Bugs component so the Drosera component can be closed and removed.