Bug 95662

Summary: NRWT: svn_revision() fails when the path is outside respository
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: Tools / TestsAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, dpranke, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dpranke: review+, webkit.review.bot: commit-queue-

Kenichi Ishibashi
Reported 2012-09-02 21:16:30 PDT
See https://bugs.webkit.org/show_bug.cgi?id=89616#c11
Attachments
Patch (1.51 KB, patch)
2012-09-02 21:20 PDT, Kenichi Ishibashi 		dpranke: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2012-09-02 21:20:31 PDT
Created attachment 161858 [details] Patch
Kenichi Ishibashi
Comment 2 2012-09-02 21:21:21 PDT
Hi Dirk, Could you take a look?
WebKit Review Bot
Comment 3 2012-09-05 15:29:38 PDT
Comment on attachment 161858 [details] Patch Rejecting attachment 161858 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: _code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitpy/common/checkout/scm/git.py Hunk #1 FAILED at 247. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitpy/common/checkout/scm/git.py.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Dirk Pranke']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/13761716
Kenichi Ishibashi
Comment 4 2012-09-05 17:32:30 PDT
The ToT has _run_git() method and it fixed the problem. The patch is no longer needed.
Note You need to log in before you can comment on or make changes to this bug.