Bug 95593

Summary: [New Multicolumn] Implement column repainting
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Dave Hyatt
Reported 2012-08-31 11:11:22 PDT
Implement column repainting. This code significantly improves over the old column code in that it can actually issue unique repaints for each column rather than doing a fuzzy unite (which is often bad when the invalidation only spans the bottom of column one and the top of column 2).
Attachments
Patch (5.57 KB, patch)
2012-08-31 11:12 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2012-08-31 11:12:50 PDT
Created attachment 161737 [details] Patch
mitz
Comment 2 2012-08-31 11:32:28 PDT
Comment on attachment 161737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161737&action=review > Source/WebCore/rendering/RenderMultiColumnSet.cpp:124 > + return floor(static_cast<float>(offset - flowThreadLogicalTop) / computedColumnHeight()); You should use floorf with a float, but here you’re returning an unsigned so you don’t need to floor at all. > Source/WebCore/rendering/RenderMultiColumnSet.cpp:341 > + LayoutUnit repaintLogicalBottom = (isHorizontalWritingMode() ? flowThreadRepaintRect.maxY() : flowThreadRepaintRect.maxX()) - 1; We should find a better way than subtracting 1 for representing “inside”.
Dave Hyatt
Comment 3 2012-08-31 11:51:21 PDT
Fixed in r127297.
Note You need to log in before you can comment on or make changes to this bug.