| Summary: | [chromium] Need to rebaseline chromium tests after hidpi changes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | alexst | ||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | alexst, eric.carlson, feature-media-reviews, jamesr, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
alexst
2012-08-31 08:26:54 PDT
Created attachment 161708 [details]
Patch
Comment on attachment 161708 [details]
Patch
Are you sure that's the correct hidpi broken image icon? It looks pretty small and doesn't match the outline well
(In reply to comment #2) > (From update of attachment 161708 [details]) > Are you sure that's the correct hidpi broken image icon? It looks pretty small and doesn't match the outline well You are correct, the broken image is small. I just checked, it does differ from the mac version as well, which I think is right. It's a separate bug unrelated to this CL, though. Asset selection seems broken. I don't believe it to be a regression introduced by this change (or the related one I am rebaselining for), all this is doing is adding the missing 3/4 of the hdpi image. I think the correct thing to do here is file the asset selection bug and rebaseline again once that's fixed. Do you agree? (In reply to comment #2) > (From update of attachment 161708 [details]) > Are you sure that's the correct hidpi broken image icon? It looks pretty small and doesn't match the outline well Actually, I think this is related. http://code.google.com/p/chromium/issues/detail?id=136118 OK, then can we rebaseline all the other tests (which do seem to be passing) and just leave a bug for the hidpi ones? (In reply to comment #5) > OK, then can we rebaseline all the other tests (which do seem to be passing) and just leave a bug for the hidpi ones? James, could you please clarify? I am not sure I understand your comment. Don't rebaseline the broken image icons in this patch since the new baselines are wrong. Instead, mark (or leave the marked) as expected failures with a link to the correct bug. (In reply to comment #7) > Don't rebaseline the broken image icons in this patch since the new baselines are wrong. Instead, mark (or leave the marked) as expected failures with a link to the correct bug. I could do that, but I think it will be a bit confusing for whoever will work on the hidpi broken image. The new baseline is no more wrong than the one it replaces as far as the broken image is concerned. If I leave them marked as broken, the test will fail because the resolutions mismatch, not because the old test had the correct image and the new one didn't. If anything, I think it would make more sense to rebaseline them with Mac versions of the 1600x1200 images and then mark as broken with a new bug. Created attachment 162514 [details]
Patch
Comment on attachment 162514 [details] Patch Clearing flags on attachment: 162514 Committed r127773: <http://trac.webkit.org/changeset/127773> All reviewed patches have been landed. Closing bug. |