Bug 95524

Summary: [EFL] Enable DFG JIT
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED INVALID    
Severity: Normal CC: lucas.de.marchi, rakuco, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-08-30 20:18:00 PDT
When enable DFG JIT, there is about 5% performance gain on Sunspider.
Attachments
Patch (2.87 KB, patch)
2012-08-30 20:22 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (2.90 KB, patch)
2012-08-30 21:30 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-08-30 20:22:12 PDT
Created attachment 161613 [details] Patch
Gyuyoung Kim
Comment 2 2012-08-30 21:08:57 PDT
Comment on attachment 161613 [details] Patch Attachment 161613 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13684968
Gyuyoung Kim
Comment 3 2012-08-30 21:30:59 PDT
Created attachment 161616 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 4 2012-08-31 01:50:19 PDT
Can you wait for staikos to reply to https://bugs.webkit.org/show_bug.cgi?id=95424#c4 , or even check that yourself as well?
Gyuyoung Kim
Comment 5 2012-08-31 01:55:30 PDT
Comment on attachment 161616 [details] Patch Ah, yes, it looks wtf/Platform.h is proper place. I will fix this patch. Thanks.
Gyuyoung Kim
Comment 6 2012-08-31 02:05:04 PDT
ENABLE_DFG_JIT should be enabled according to the kind of platform. So, cmake is not proper place for this macro. In addition, this feature is enabled on X86, X86_64 and linux by default when JIT is enabled. http://trac.webkit.org/browser/trunk/Source/WTF/wtf/Platform.h#L921
Raphael Kubo da Costa (:rakuco)
Comment 7 2012-08-31 02:08:45 PDT
I don't really like implicit detections in Platform.h, but changing that probably requires some time and patience to deal with everyone involved.
Gyuyoung Kim
Comment 8 2012-08-31 02:22:00 PDT
(In reply to comment #7) > I don't really like implicit detections in Platform.h, but changing that probably requires some time and patience to deal with everyone involved. Yes, explicit feature detection is more clear. But, as you said, this needs to discuss with webkit-dev before we modify. Anyway, thank you for your comment.
Note You need to log in before you can comment on or make changes to this bug.