Bug 95518

Summary: Loading a worker script should not be O(n^2)
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-08-30 18:06:34 PDT
Loading a worker script should not be O(n^2)
Attachments
Patch (3.60 KB, patch)
2012-08-30 18:08 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-08-30 18:08:04 PDT
Created attachment 161598 [details] Patch
Adam Barth
Comment 2 2012-08-30 18:08:37 PDT
Elsewhere we use SegmentedString to do similar work, but there doesn't seem to be any advantage to using SegmentedString here.
Benjamin Poulain
Comment 3 2012-08-30 19:32:19 PDT
Comment on attachment 161598 [details] Patch The patch looks good. JavaScriptCore has an optimized class for joining a list of WTF::String with an optional delimiter: JSStringJoiner. JSStringJoiner is very specific to JSC (allocation with tryXXX and the number of strings must be known in advance). If the pattern of this patch appears in sections where performance is critical, we should write a StringJoiner for WTF.
WebKit Review Bot
Comment 4 2012-08-30 21:00:31 PDT
Comment on attachment 161598 [details] Patch Clearing flags on attachment: 161598 Committed r127227: <http://trac.webkit.org/changeset/127227>
WebKit Review Bot
Comment 5 2012-08-30 21:00:36 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 6 2012-08-30 21:21:17 PDT
We probably don't need anything super efficient. Just something not brain dead.
Note You need to log in before you can comment on or make changes to this bug.