Bug 95515 – REGRESSION (127047): Crash in PluginProxy::windowVisibilityChanged when changing tabs

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Jim Oase]

Crash generally happens when changing windows or tabs.

[Alexey Proskuryakov]

Thank you for the report. Could you please attach a crash log?

[Jim Oase]

Created attachment 161685 [details]
Crash Report... from crash dialog prior to being sent to Apple

When I checked the root level Crash Log it was empty... so I reloaded the offending build and it crashed immediately.  Attached is the crash report from that crash prior to sending it to Apple.

[Alexey Proskuryakov]

<rdar://problem/12211180>

[Brady Eidson]

Jim please include more specific steps on how to reproduce this.  Specific URLs you have open, for example.

[Brady Eidson]

Nevermind, figured out how to repro.

The key is to open a page with plugin's in a background tab, then start switching between tabs.

It's a PluginView representing a Plug-in that has never been initialized.

Instead of :
void PluginView::setWindowIsFocused(bool windowIsFocused)
{
    if (!m_plugin)
        return;
...


We need:
void PluginView::setWindowIsFocused(bool windowIsFocused)
{
    if (!m_isInitialized || !m_plugin)
        return;

[Brady Eidson]

Created attachment 161720 [details]
Patch

No realistic way to test this

[Jim Oase]

I have installed nightly build   Version 6.0 (8536.25, 537+) since reporting the problem.  The crash problems have not occurred since.

[Alexey Proskuryakov]

Looks like this has been landed in <http://trac.webkit.org/changeset/127272>.