Bug 95493

Summary:

[Tests] Add basic tests to http/tests/notifications

Product:

WebKit

Reporter:

Jon Lee <jonlee>

Component:

Tools / Tests

Assignee:

Jon Lee <jonlee>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, dglazkov, gyuyoung.kim, jberlin, rakuco, webkit-bug-importer, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.8

Bug Depends on:

95233

Bug Blocks:

77969

Attachments:

Description	Flags
WIP Patch	none
Patch	none
Patch	none
Patch	ap: review+

Description Jon Lee 2012-08-30 13:17:23 PDT

Include a few tests that test the notifications API for DRT and WTR.

Comment 1 Radar WebKit Bug Importer 2012-08-30 13:18:44 PDT

<rdar://problem/12209303>

Comment 2 Jon Lee 2012-08-30 13:31:50 PDT

Created attachment 161542 [details]
WIP Patch

Comment 3 WebKit Review Bot 2012-08-30 17:44:56 PDT

Comment on attachment 161542 [details]
WIP Patch

Attachment 161542 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13682936

New failing tests:
http/tests/notifications/show.html
http/tests/notifications/request.html

Comment 4 Jon Lee 2012-08-31 00:28:59 PDT

Created attachment 161627 [details]
Patch

Comment 5 Build Bot 2012-08-31 00:56:35 PDT

Comment on attachment 161627 [details]
Patch

Attachment 161627 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13716072

Comment 6 Jon Lee 2012-08-31 01:01:21 PDT

Created attachment 161631 [details]
Patch

Comment 7 Build Bot 2012-08-31 01:32:42 PDT

Comment on attachment 161631 [details]
Patch

Attachment 161631 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13722064

Comment 8 Jon Lee 2012-08-31 10:48:46 PDT

Created attachment 161733 [details]
Patch

Comment 9 Alexey Proskuryakov 2012-08-31 12:03:16 PDT

Comment on attachment 161733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161733&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:78
> +WK_EXPORT uint64_t WKBundleGetWebNotificationID(WKBundleRef bundle, JSContextRef context, JSValueRef notification);

Should these methods be ForTesting?

Comment 10 Jon Lee 2012-08-31 12:06:36 PDT

Comment on attachment 161733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=161733&action=review

>> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:78
>> +WK_EXPORT uint64_t WKBundleGetWebNotificationID(WKBundleRef bundle, JSContextRef context, JSValueRef notification);
> 
> Should these methods be ForTesting?

They could be. I just followed style. That whole section is just TestRunner SPI.

Comment 11 Jon Lee 2012-08-31 12:08:20 PDT

Committed r127299: <http://trac.webkit.org/changeset/127299>

Comment 12 Jessie Berlin 2012-08-31 13:23:07 PDT

(In reply to comment #11)
> Committed r127299: <http://trac.webkit.org/changeset/127299>

This caused 4 tests to start failing on Lion. Please fix soon or roll out your patch, because those 4 tests are the only thing standing between that bot and green right now.