Bug 95488 – [BlackBerry] when one of multiple tabs uses authentication, user can get the auth dialog while the other tab has focus.

• Component: WebKit BlackBerry
• Status: RESOLVED FIXED

[Lyon Chen]

Observed Result:
Constantly being prompted for username/password when one of multiple tabs uses
NTLM style authentication

Expected Result:
Should not be prompted for username/password more than once when using multiple
tabs

Steps To Reproduce:
open a tab and browse to a NTLM authenticated site
http://lifeatrim.rim.net/

enter the rim account name and password to login to the site
open a new tab and browse to another site such as www.rim.com

[Lyon Chen]

Add [BlackBerry] to title.

[Lyon Chen]

Add Yong, Joe, and Rob.

[Lyon Chen]

Created attachment 162653 [details]
First patch for 95488

[Yong Li]

Comment on attachment 162653 [details]
First patch for 95488

View in context: https://bugs.webkit.org/attachment.cgi?id=162653&action=review

> Source/WebCore/ChangeLog:8
> +
> +        Add AuthenticationChallengeClient interface to support asynchronous

Better put the RIM PR number here, so we will be able to link the commit to the PR

> Source/WebCore/ChangeLog:16
> +        Note: this patch itself will not fix this bug, but it prepares the base
> +        for the next patch by making the authentication asynchronous to NetworkJob
> +        and MediaPlayerPrivateBlackBerry.

why not put them together? That will make it easier for reviewer to understand how it will work

> Source/WebCore/ChangeLog:18
> +        No new tests as there is no change of behavior.

Doing it in async mode is a big behavior change, with your next patch :) We don't have to upstream a layout test for our platform-specific test though.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:832
> +    if (result != AuthenticationChallengeSuccess
> +            || protectionSpace.host().isEmpty()
> +            || !url.isValid()) {

style: using one line is good enough?

[Yong Li]

Comment on attachment 162653 [details]
First patch for 95488

please put "internally reviewed by Joe Mason" in the change log. otherwise r+

[Lyon Chen]

Created attachment 162777 [details]
Patch updated based on Yong's comments.

Yong: thanks, this is the updated patch, please check whether it is OK or need further improvement.

[WebKit Review Bot]

Comment on attachment 162777 [details]
Patch updated based on Yong's comments.

Clearing flags on attachment: 162777

Committed r127884: <http://trac.webkit.org/changeset/127884>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.