Bug 95442

Summary: New fast/events/set-attribute-listener-window-onerror-crash.html fails on JSC platforms
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: anton muhin <antonm>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, antonm, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2012-08-30 04:15:15 PDT
It introduced in https://trac.webkit.org/changeset/127117 (https://bugs.webkit.org/show_bug.cgi?id=94440 is security bug) --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/set-attribute-listener-window-onerror-crash-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/set-attribute-listener-window-onerror-crash-actual.txt @@ -1,2 +1,2 @@ -CONSOLE MESSAGE: line 16: Uncaught SyntaxError: Unexpected token ; +CONSOLE MESSAGE: line 16: SyntaxError: Unexpected token ';' Test passes if it does not crash. As far as I remember the consensus is that platform independent result should be the JSC one it JSC and V8 results are different. Could you update it, please?
Attachments
Patch (1.85 KB, patch)
2012-08-30 04:49 PDT, anton muhin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
anton muhin
Comment 1 2012-08-30 04:30:40 PDT
Sure, will do and sorry for inconvenience. (In reply to comment #0) > It introduced in https://trac.webkit.org/changeset/127117 > (https://bugs.webkit.org/show_bug.cgi?id=94440 is security bug) > > --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/set-attribute-listener-window-onerror-crash-expected.txt > +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/events/set-attribute-listener-window-onerror-crash-actual.txt > @@ -1,2 +1,2 @@ > -CONSOLE MESSAGE: line 16: Uncaught SyntaxError: Unexpected token ; > +CONSOLE MESSAGE: line 16: SyntaxError: Unexpected token ';' > Test passes if it does not crash. > > As far as I remember the consensus is that platform independent > result should be the JSC one it JSC and V8 results are different. > Could you update it, please?
anton muhin
Comment 2 2012-08-30 04:49:27 PDT
Created attachment 161442 [details] Patch
Csaba Osztrogonác
Comment 3 2012-08-30 04:51:09 PDT
Comment on attachment 161442 [details] Patch Not problem, thanks for the quick fix.
Csaba Osztrogonác
Comment 4 2012-08-30 05:59:05 PDT
Comment on attachment 161442 [details] Patch Clearing flags on attachment: 161442 Committed r127129: <http://trac.webkit.org/changeset/127129>
Csaba Osztrogonác
Comment 5 2012-08-30 05:59:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.