Bug 95441 – [Qt] REGRESSION(r122175): fast/loader/document-destruction-within-unload.html makes the following test assert

• Component: New Bugs
• Status: RESOLVED DUPLICATE

[Csaba Osztrogonác]

crash log for DumpRenderTree (pid 13596):
STDOUT: <empty>
STDERR: ASSERTION FAILED: m_inProgress
STDERR: /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/Source/WebCore/loader/FrameLoader.cpp(188) : void WebCore::FrameLoader::FrameProgressTracker::progressCompleted()
STDERR: 1   0x7f462acb4f48 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1090f48) [0x7f462acb4f48]
STDERR: 2   0x7f462acc04d1 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x109c4d1) [0x7f462acc04d1]
STDERR: 3   0x7f462acc1454 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x109d454) [0x7f462acc1454]
STDERR: 4   0x7f462acbd94f /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x109994f) [0x7f462acbd94f]
STDERR: 5   0x7f462a10cc6c /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/lib/libQtWebKit.so.5(_ZN8QWebPage13triggerActionENS_9WebActionEb+0xae8) [0x7f462a10cc6c]
STDERR: 6   0x415743 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/bin/DumpRenderTree() [0x415743]
STDERR: 7   0x415eec /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/bin/DumpRenderTree() [0x415eec]
STDERR: 8   0x417315 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/bin/DumpRenderTree() [0x417315]
STDERR: 9   0x416475 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/bin/DumpRenderTree() [0x416475]
STDERR: 10  0x42c626 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/bin/DumpRenderTree() [0x42c626]
STDERR: 11  0x7f4627a0a29e /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN7QObject5eventEP6QEvent+0x36e) [0x7f4627a0a29e]
STDERR: 12  0x7f462904649c /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtWidgets.so.5(_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent+0xac) [0x7f462904649c]
STDERR: 13  0x7f462904ca2d /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtWidgets.so.5(_ZN12QApplication6notifyEP7QObjectP6QEvent+0x11d) [0x7f462904ca2d]
STDERR: 14  0x7f46279e53d4 /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN16QCoreApplication14notifyInternalEP7QObjectP6QEvent+0x84) [0x7f46279e53d4]
STDERR: 15  0x7f46279ea359 /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN23QCoreApplicationPrivate16sendPostedEventsEP7QObjectiP11QThreadData+0x279) [0x7f46279ea359]
STDERR: 16  0x7f4627a30b33 /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(+0x26cb33) [0x7f4627a30b33]
STDERR: 17  0x7f462d8e06f2 /lib/libglib-2.0.so.0(g_main_context_dispatch+0x1f2) [0x7f462d8e06f2]
STDERR: 18  0x7f462d8e4568 /lib/libglib-2.0.so.0(+0x42568) [0x7f462d8e4568]
STDERR: 19  0x7f462d8e471c /lib/libglib-2.0.so.0(g_main_context_iteration+0x6c) [0x7f462d8e471c]
STDERR: 20  0x7f4627a3060b /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN20QEventDispatcherGlib13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE+0x6b) [0x7f4627a3060b]
STDERR: 21  0x7f46279e452b /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE+0x10b) [0x7f46279e452b]
STDERR: 22  0x7f46279ea995 /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN16QCoreApplication4execEv+0xb5) [0x7f46279ea995]
STDERR: 23  0x42c24b /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/bin/DumpRenderTree() [0x42c24b]
STDERR: 24  0x7f46262eac8d /lib/libc.so.6(__libc_start_main+0xfd) [0x7f46262eac8d]
STDERR: 25  0x410ad9 /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/WebKitBuild/Debug/bin/DumpRenderTree() [0x410ad9]

It passes if you run only this test, but crash if you run the test before it too:
$Tool/Scripts/run-webkit-tests --debug fast/loader/document-destruction-within-unload.html fast/loader/document-with-fragment-url-1.html

[Csaba Osztrogonác]

I skipped fast/loader/document-destruction-within-unload.html to make
the debug bot happier - https://trac.webkit.org/changeset/127120

Please unskip it with the proper fix.

[Nate Chapin]

(In reply to comment #1)
> I skipped fast/loader/document-destruction-within-unload.html to make
> the debug bot happier - https://trac.webkit.org/changeset/127120
> 
> Please unskip it with the proper fix.

That crash stack is missing a bunch of symbols and I can't find the buildbot that stack appears to have come from. Am I missing something?

[Csaba Osztrogonác]

(In reply to comment #2)
> (In reply to comment #1)
> > I skipped fast/loader/document-destruction-within-unload.html to make
> > the debug bot happier - https://trac.webkit.org/changeset/127120
> > 
> > Please unskip it with the proper fix.
> 
> That crash stack is missing a bunch of symbols and I can't find the buildbot that stack appears to have come from. Am I missing something?

You can find this bot here: http://build.webkit.sed.hu/waterfall (the 3rd slave) - x86-64 Linux Qt Debug

You're right the backtrace generated by the bot isn't so good ... I created
a better one with gdb:

$ gdb WebKitBuild/Debug/bin/DumpRenderTree
GNU gdb (GDB) 7.0.1-debian
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree...done.
(gdb) run LayoutTests/fast/loader/document-destruction-within-unload.html LayoutTests/fast/loader/document-with-fragment-url-1.html
Starting program: /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree LayoutTests/fast/loader/document-destruction-within-unload.html LayoutTests/fast/loader/document-with-fragment-url-1.html
[Thread debugging using libthread_db enabled]
[New Thread 0x7fffa60c3700 (LWP 32455)]
[Thread 0x7fffa60c3700 (LWP 32455) exited]
[New Thread 0x7fffa60c3700 (LWP 32632)]
[New Thread 0x7fffa55bd700 (LWP 32634)]
Source:

<html><head></head><body>
<script>
if (window.testRunner) {
    testRunner.dumpAsText();
    testRunner.waitUntilDone();
}

function done() {
    if (window.testRunner)
        testRunner.notifyDone();
}
</script>
<iframe src="resources/document-destruction-within-unload-iframe.html"></iframe>
<p>For the test to pass there should be no crash.</p>


</body></html>
Content-Type: text/plain

For the test to pass there should be no crash.
#EOF
#EOF
#EOF
ASSERTION FAILED: m_inProgress
/home/oszi/WebKit/Source/WebCore/loader/FrameLoader.cpp(188) : void WebCore::FrameLoader::FrameProgressTracker::progressCompleted()
1   0x7ffff307d0c0 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x10910c0) [0x7ffff307d0c0]
2   0x7ffff3088649 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x109c649) [0x7ffff3088649]
3   0x7ffff30895cc /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x109d5cc) [0x7ffff30895cc]
4   0x7ffff3085ac7 /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(+0x1099ac7) [0x7ffff3085ac7]
5   0x7ffff24d4e8c /home/oszi/WebKit/WebKitBuild/Debug/lib/libQtWebKit.so.5(_ZN8QWebPage13triggerActionENS_9WebActionEb+0xae8) [0x7ffff24d4e8c]
6   0x415713 /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree() [0x415713]
7   0x415ebc /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree() [0x415ebc]
8   0x4172e5 /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree() [0x4172e5]
9   0x416b43 /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree() [0x416b43]
10  0x42c763 /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree() [0x42c763]
11  0x7fffefdd229e /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN7QObject5eventEP6QEvent+0x36e) [0x7fffefdd229e]
12  0x7ffff140e49c /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtWidgets.so.5(_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent+0xac) [0x7ffff140e49c]
13  0x7ffff1414a2d /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtWidgets.so.5(_ZN12QApplication6notifyEP7QObjectP6QEvent+0x11d) [0x7ffff1414a2d]
14  0x7fffefdad3d4 /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN16QCoreApplication14notifyInternalEP7QObjectP6QEvent+0x84) [0x7fffefdad3d4]
15  0x7fffefdb2359 /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN23QCoreApplicationPrivate16sendPostedEventsEP7QObjectiP11QThreadData+0x279) [0x7fffefdb2359]
16  0x7fffefdf8b33 /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(+0x26cb33) [0x7fffefdf8b33]
17  0x7ffff5b276f2 /lib/libglib-2.0.so.0(g_main_context_dispatch+0x1f2) [0x7ffff5b276f2]
18  0x7ffff5b2b568 /lib/libglib-2.0.so.0(+0x42568) [0x7ffff5b2b568]
19  0x7ffff5b2b71c /lib/libglib-2.0.so.0(g_main_context_iteration+0x6c) [0x7ffff5b2b71c]
20  0x7fffefdf860b /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN20QEventDispatcherGlib13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE+0x6b) [0x7fffefdf860b]
21  0x7fffefdac52b /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE+0x10b) [0x7fffefdac52b]
22  0x7fffefdb2995 /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5(_ZN16QCoreApplication4execEv+0xb5) [0x7fffefdb2995]
23  0x42c21b /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree() [0x42c21b]
24  0x7fffee6b2c8d /lib/libc.so.6(__libc_start_main+0xfd) [0x7fffee6b2c8d]
25  0x410aa9 /home/oszi/WebKit/WebKitBuild/Debug/bin/DumpRenderTree() [0x410aa9]

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff307d0ca in WebCore::FrameLoader::FrameProgressTracker::progressCompleted (this=0x55a320) at /home/oszi/WebKit/Source/WebCore/loader/FrameLoader.cpp:188
188             ASSERT(m_inProgress);
(gdb) bt
#0  0x00007ffff307d0ca in WebCore::FrameLoader::FrameProgressTracker::progressCompleted (this=0x55a320) at /home/oszi/WebKit/Source/WebCore/loader/FrameLoader.cpp:188
#1  0x00007ffff3088649 in WebCore::FrameLoader::checkLoadCompleteForThisFrame (this=0x5509b0) at /home/oszi/WebKit/Source/WebCore/loader/FrameLoader.cpp:2162
#2  0x00007ffff30895cc in WebCore::FrameLoader::checkLoadComplete (this=0x491760) at /home/oszi/WebKit/Source/WebCore/loader/FrameLoader.cpp:2353
#3  0x00007ffff3085ac7 in WebCore::FrameLoader::stopForUserCancel (this=0x491760, deferCheckLoadComplete=false) at /home/oszi/WebKit/Source/WebCore/loader/FrameLoader.cpp:1584
#4  0x00007ffff24d4e8c in QWebPage::triggerAction (this=0x7fffa00034c0, action=QWebPage::Stop) at /home/oszi/WebKit/Source/WebKit/qt/Api/qwebpage.cpp:2399
#5  0x0000000000415713 in WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting (this=0x7fffffffe080, url=...) at /home/oszi/WebKit/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:515
#6  0x0000000000415ebc in WebCore::DumpRenderTree::open (this=0x7fffffffe080, url=...) at /home/oszi/WebKit/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:599
#7  0x00000000004172e5 in WebCore::DumpRenderTree::processLine (this=0x7fffffffe080, input=...) at /home/oszi/WebKit/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:719
#8  0x0000000000416b43 in WebCore::DumpRenderTree::loadNextTestInStandAloneMode (this=0x7fffffffe080) at /home/oszi/WebKit/Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:686
#9  0x000000000042c763 in WebCore::DumpRenderTree::qt_static_metacall (_o=0x7fffffffe080, _c=QMetaObject::InvokeMetaMethod, _id=15, _a=0x53b960) at moc_DumpRenderTreeQt.cpp:155
#10 0x00007fffefdd229e in QObject::event(QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5
#11 0x00007ffff140e49c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtWidgets.so.5
#12 0x00007ffff1414a2d in QApplication::notify(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtWidgets.so.5
#13 0x00007fffefdad3d4 in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5
#14 0x00007fffefdb2359 in QCoreApplicationPrivate::sendPostedEvents(QObject*, int, QThreadData*) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5
#15 0x00007fffefdf8b33 in ?? () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5
#16 0x00007ffff5b276f2 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
#17 0x00007ffff5b2b568 in ?? () from /lib/libglib-2.0.so.0
#18 0x00007ffff5b2b71c in g_main_context_iteration () from /lib/libglib-2.0.so.0
#19 0x00007fffefdf860b in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5
#20 0x00007fffefdac52b in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5
#21 0x00007fffefdb2995 in QCoreApplication::exec() () from /usr/local/Trolltech/Qt5/Qt-5.0.0-r36/lib/libQtCore.so.5
#22 0x000000000042c21b in main (argc=3, argv=0x7fffffffe378) at /home/oszi/WebKit/Tools/DumpRenderTree/qt/main.cpp:196

[Nate Chapin]

This is the same failing test and same root cause as bugs.webkit.org/show_bug.cgi?id=66783, patch uploaded there

[Csaba Osztrogonác]

(In reply to comment #4)
> This is the same failing test and same root cause as bugs.webkit.org/show_bug.cgi?id=66783, patch uploaded there

I tried https://bugs.webkit.org/attachment.cgi?id=161584 , and it works on Qt i debug mode. Thanks for the fix.

[Nate Chapin]

(In reply to comment #5)
> (In reply to comment #4)
> > This is the same failing test and same root cause as bugs.webkit.org/show_bug.cgi?id=66783, patch uploaded there
> 
> I tried https://bugs.webkit.org/attachment.cgi?id=161584 , and it works on Qt i debug mode. Thanks for the fix.

*** This bug has been marked as a duplicate of bug 66783 ***